(#68) Added tests for new type/provider and removed CentOS8 Support (#69)

* (#68) Added tests for new type/provider and removed CentOS8 Support

Fixes #67
Fixes #68

* Fixed Rubocop issues

Author: michael-riddle

data/os/CentOS-8.yaml

@@ -45,7 +45,6 @@
     {
       "operatingsystem": "CentOS",
       "operatingsystemrelease": [
-        "8",
         "9",
         "10"
       ]
@@ -54,7 +53,8 @@
       "operatingsystem": "OracleLinux",
       "operatingsystemrelease": [
         "8",
-        "9"
+        "9",
+        "10"
       ]
     },
     {
@@ -69,7 +69,8 @@
       "operatingsystem": "Rocky",
       "operatingsystemrelease": [
         "8",
-        "9"
+        "9",
+        "10"
       ]
     },
     {

metadata.json

@@ -0,0 +1,81 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'puppet'
+
+describe Puppet::Type.type(:ds389_nss_token).provider(:ruby) do
+  let(:instance_dir) { '/tmp/slapd-test' }
+  let(:token_path) { File.join(instance_dir, 'token.txt') }
+  let(:pin_path) { File.join(instance_dir, 'pin.txt') }
+  let(:pwdfile) { File.join(instance_dir, 'pwdfile.txt') }
+
+  let(:resource) do
+    Puppet::Type.type(:ds389_nss_token).new(
+      name: 'test_instance_nss_token',
+      instance_name: 'test_instance',
+      instance_dir: instance_dir,
+    )
+  end
+
+  let(:provider) { Puppet::Type.type(:ds389_nss_token).provider(:ruby).new(resource) }
+
+  before(:each) do
+    FileUtils.mkdir_p(instance_dir)
+    File.write(pwdfile, "defaultpw\n")
+  end
+
+  after(:each) do
+    FileUtils.rm_rf(instance_dir)
+  end
+
+  describe '#exists?' do
+    it 'returns false when token file is missing' do
+      expect(provider.exists?).to be false
+    end
+
+    it 'returns true when token file exists' do
+      File.write(token_path, 'abc')
+      expect(provider.exists?).to be true
+    end
+  end
+
+  describe '#desired_token' do
+    it 'uses user token if supplied' do
+      resource[:token] = 'usertoken'
+      expect(provider.desired_token).to eq('usertoken')
+    end
+
+    it 'falls back to pwdfile.txt when no user token' do
+      expect(provider.desired_token).to eq('defaultpw')
+    end
+  end
+
+  describe '#create' do
+    it 'creates token.txt and pin.txt' do
+      provider.create
+      expect(File.read(token_path).strip).to eq('defaultpw')
+      expect(File.read(pin_path).strip).to eq('Internal (Software) Token:defaultpw')
+    end
+
+    it 'backs up old token file' do
+      File.write(token_path, 'oldvalue')
+      provider.create
+      expect(File.exist?(File.join(instance_dir, 'token.txt.previous_token'))).to be false
+    end
+
+    it 'raises error if instance_dir missing' do
+      resource[:instance_dir] = '/no/such/path'
+      expect { provider.create }.to raise_error(Puppet::Error)
+    end
+  end
+
+  describe '#destroy' do
+    it 'removes token and pin files' do
+      File.write(token_path, 'x')
+      File.write(pin_path, 'x')
+      provider.destroy
+      expect(File.exist?(token_path)).to be false
+      expect(File.exist?(pin_path)).to be false
+    end
+  end
+end

spec/unit/puppet/provider/ds389_nss_token/ruby_spec.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Puppet::Type.type(:ds389_nss_token) do
+  let(:resource) do
+    described_class.new(
+      name: 'test_instance_nss_token',
+      instance_name: 'test_instance',
+      instance_dir: '/etc/dirsrv/slapd-test_instance',
+    )
+  end
+
+  context 'attribute :name' do
+    it 'is the namevar' do
+      expect(described_class.key_attributes).to eq([:name])
+    end
+  end
+
+  context 'parameter :instance_name' do
+    it 'accepts a valid value' do
+      resource[:instance_name] = 'ldap01'
+      expect(resource[:instance_name]).to eq('ldap01')
+    end
+
+    it 'rejects an empty value' do
+      expect {
+        described_class.new(
+          name: 'bad',
+          instance_name: '',
+          instance_dir: '/tmp',
+        )
+      }.to raise_error(Puppet::ResourceError, %r{must not be empty})
+    end
+  end
+
+  context 'parameter :instance_dir' do
+    it 'accepts an absolute path' do
+      resource[:instance_dir] = '/opt/slapd'
+      expect(resource[:instance_dir]).to eq('/opt/slapd')
+    end
+
+    it 'rejects a relative path' do
+      expect {
+        described_class.new(
+          name: 'bad',
+          instance_name: 'x',
+          instance_dir: 'not_absolute',
+        )
+      }.to raise_error(Puppet::ResourceError, %r{must be an absolute path})
+    end
+  end
+
+  context 'property :status' do
+    it 'allows any value (no validation)' do
+      resource[:status] = 'in_sync'
+      expect(resource[:status]).to eq('in_sync')
+    end
+  end
+
+  context 'autorequires' do
+    it 'autorequires the instance directory' do
+      file_resource = Puppet::Type::File.new(path: resource[:instance_dir])
+      catalog = Puppet::Resource::Catalog.new
+      catalog.add_resource file_resource
+      catalog.add_resource resource
+
+      expect(resource.autorequire.map(&:source)).to include(file_resource)
+    end
+  end
+end