Skip to content

Commit 8120ec2

Browse files
committed
Run just "sdist", not "build sdist" in the publush job to make sure
no garbage gets included into sdist. Rename stuff for clarity.
1 parent 1605e15 commit 8120ec2

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

.github/workflows/build_and_test.yml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ permissions:
2121

2222
# A workflow run is made up of one or more jobs that can run sequentially or in parallel
2323
jobs:
24-
build_and_test_python:
24+
build_test_python:
25+
name: Build&Test
2526
strategy:
2627
fail-fast: false
2728
matrix:
@@ -61,7 +62,9 @@ jobs:
6162
shell: bash
6263

6364
- name: build
64-
run: CC=${COMPILER} LDSHARED="${COMPILER} -shared" python setup.py build sdist
65+
run: |
66+
python setup.py sdist
67+
CC=${COMPILER} LDSHARED="${COMPILER} -shared" python setup.py build
6568
shell: bash
6669

6770
- name: install
@@ -74,12 +77,14 @@ jobs:
7477
shell: bash
7578

7679
build_wheels:
80+
name: Build Python Wheels
7781
permissions:
7882
packages: write
79-
needs: build_and_test_python
83+
needs: build_test_python
8084
uses: sippy/cimagic/.github/workflows/BuildPythonWheels.yml@v1
8185

8286
publish_all_wheels:
87+
name: Pubpish Python Wheels
8388
runs-on: ubuntu-latest
8489
needs: build_wheels
8590
environment:
@@ -109,8 +114,8 @@ jobs:
109114
python -m pip install --upgrade pip
110115
pip install --upgrade build setuptools wheel
111116
112-
- name: build
113-
run: python setup.py build sdist
117+
- name: Build SDist
118+
run: python setup.py sdist
114119

115120
- name: Show context tree
116121
run: ls -lR dist
@@ -120,6 +125,7 @@ jobs:
120125
uses: pypa/gh-action-pypi-publish@release/v1
121126

122127
roll_release:
128+
name: Release
123129
needs: publish_all_wheels
124130
permissions:
125131
contents: write

0 commit comments

Comments
 (0)