Refresh method doesn't do as advertised

[jayden2]

Docs state:

refresh()
# Returns a promise
Refresh all properties and elements of the tour. This includes re-computing tour steps.

However if I init a tour, go through the tour step(s).
Then remove some of the elements and create new ones. Say I remove table rows, then added the table rows again.
Re-opening the tour and using refresh() (also tried refreshDialog() and updatePositions()) Does not recompute a new element and the tour selector goes to the top left of the page.

This is using js to select, instead of html properties

{
        title: 'title',
        content: 'text​​',
        target: '#table-1 td',
        group: 'guide_1',
        fixed: false,
}

This happens because the target is replaced on init with a selected element, it would be useful to have another function to maybe reselect elements or include that in refresh.
To me it is also strange that the config's target (value) is replaced with the selected element.

---

It would also be really useful to be able to destroy the tour instance.

[Pinch1A]

same issue here ! I tried everything. but if I exit the tour and move to another route and then I get back to the page where the tour runs, it moves to the top left corner after the first step.

what can we do about it ? this way we have no control of it.

[mcrampon]

It's particularly painful in SPAs, where the DOM is completely altered but the TourGuideClient instance still believes it has a valid backdrop/dialog/whatnot. We need to be able to completely reset the instance.

[Pinch1A]

I found the reason why that happens, and a workaround.
if for some reason we create new TourGuideCliente after we already started one (even if we finished it) it will use as step's target the dom element already resolved instead of the string we defined during configuration.

So If we sanitize the target whenever is needed using what we put initially as a string it won't brake again 🔢