-
Notifications
You must be signed in to change notification settings - Fork 131
TEST CI DO NOT MERGE #1889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
TEST CI DO NOT MERGE #1889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mission in unit test, update unit test imports
…uterService for test to work.
… if device is not an emulator, New emulator actually works, so to prevent incompatibility with older emulators only check on actual devices
…ities, only doing certain checks on API levels less then 30 for WiFiSocketFactoryTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Things to note: Pull Requests must fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the Contributing Guide for information on branch naming and the CLA, and the SmartDeviceLink GitHub Best Practices document for more information on how to enter a pull request. Once this PR is ready for review, please request one from @joeygrover.
Delete the above section when you've read it.]
Fixes #[issue number]
This PR is [ready / not ready] for review.
Risk
This PR makes [no / minor / major] API changes.
Testing Plan
Unit Tests
[Describe the unit tests and behaviors added in this PR]
Core Tests
[List of tests performed against Core and behaviors verified]
Core version / branch / commit hash / module tested against: [INSERT]
HMI name / version / branch / commit hash / module tested against: [INSERT]
Summary
[Summary of PR changes]
Changelog
Breaking Changes
Enhancements
Bug Fixes
Tasks Remaining:
CLA