Commit f6336bc
authored
[expo-router] Fix modal with detents fixToContents on Android (expo#38440)
# Why
When modal was used with presentationStyle `formsheet` and detents
`fitToContents`, the on Android it took all available space, instead of
just contents.
## Before
https://github.com/user-attachments/assets/cdb5ce21-4470-4603-960b-6f5c54e72420
## After
https://github.com/user-attachments/assets/67225dac-14fd-4a33-b5db-92084f94c8fb
# How
1. When presentationStyle is `formsheet` and detents are
`fitToContents`, the flex property is set to `undefined`
# Test Plan
1. Manual testing on Android and iOS
# Checklist
<!--
Please check the appropriate items below if they apply to your diff.
-->
- [x] I added a `changelog.md` entry and rebuilt the package sources
according to [this short
guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)1 parent 0234a4f commit f6336bc
File tree
4 files changed
+4
-3
lines changed- packages/expo-router
- build/modal
- src/modal
4 files changed
+4
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
0 commit comments