Skip to content

Commit 73bdb03

Browse files
authored
fix: CMake flags (#2603)
# Summary Fix typo in CMakeLists.txt flags and use `ReactAndroid_VERSION_MINOR` instead of `REACT_NATIVE_MINOR_VERSION` ## Test Plan Example apps should build without warnings/errors on 0.73+ as well as on 0.77.0-rc.6
1 parent d888de9 commit 73bdb03

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

android/build.gradle

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -104,13 +104,6 @@ android {
104104
buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString()
105105

106106
consumerProguardFiles 'proguard-rules.pro'
107-
108-
buildConfigField("String", "REACT_NATIVE_MINOR_VERSION", "\"${REACT_NATIVE_MINOR_VERSION}\"")
109-
externalNativeBuild {
110-
cmake {
111-
arguments "-DREACT_NATIVE_MINOR_VERSION=${REACT_NATIVE_MINOR_VERSION}"
112-
}
113-
}
114107
}
115108
lintOptions {
116109
abortOnError false

android/src/main/jni/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ set(RNS_GENERATED_REACT_DIR ${RNS_GENERATED_JNI_DIR}/react/renderer/components/r
1010
string(
1111
APPEND
1212
CMAKE_CXX_FLAGS
13-
" -DREACT_NATIVE_MINOR_VERSION=321${REACT_NATIVE_MINOR_VERSION}")
13+
" -DREACT_NATIVE_MINOR_VERSION=${ReactAndroid_VERSION_MINOR}")
1414

1515
add_compile_options(
1616
-fexceptions

0 commit comments

Comments
 (0)