test: fix JSONRPCEngine mock and ControllerAccount test typings\n\n- Replace wrapper MockConnection with subclass of MockJSONRPCEngine\n- Import SSFModels and type Cuckoo matchers in ControllerAccountTests\n- Align wireframe present signatures to SheetAlertPresentable types

Signed-off-by: William Richter <[email protected]>

Author: WRRicht3r

fearlessTests/Common/Services/ChainRegistry/MockConnection.swift

@@ -1,69 +1,5 @@
 import Foundation
 @testable import fearless
-import SSFUtils
 
-final class MockConnection {
-    let internalConnection = MockJSONRPCEngine()
-}
-
-extension MockConnection: JSONRPCEngine {
-    var url: URL? {
-        get { internalConnection.url }
-        set { internalConnection.url = newValue }
-    }
-
-    var pendingEngineRequests: [JSONRPCRequest] { internalConnection.pendingEngineRequests }
-
-    func reconnect(url: URL) {
-        internalConnection.reconnect(url: url)
-    }
-
-    func connectIfNeeded() {
-        internalConnection.connectIfNeeded()
-    }
-
-    func disconnectIfNeeded() {
-        internalConnection.disconnectIfNeeded()
-    }
-
-    func connect(with pendingRequests: [JSONRPCRequest]) {
-        // Forwarding connect helper (if needed in future tests)
-        // No-op for now; tests use call/subscribe directly
-    }
-
-    func generateRequestId() -> UInt16 { internalConnection.generateRequestId() }
-
-    func addSubscription(_ subscription: JSONRPCSubscribing) { internalConnection.addSubscription(subscription) }
-
-    func callMethod<P, T>(
-        _ method: String,
-        params: P?,
-        options: JSONRPCOptions,
-        completion closure: ((Result<T, Error>) -> Void)?
-    ) throws -> UInt16 where P: Encodable, T: Decodable {
-        try internalConnection.callMethod(
-            method,
-            params: params,
-            options: options,
-            completion: closure
-        )
-    }
-
-    func subscribe<P, T>(
-        _ method: String,
-        params: P?,
-        updateClosure: @escaping (T) -> Void,
-        failureClosure: @escaping (Error, Bool) -> Void
-    ) throws -> UInt16 where P: Encodable, T: Decodable {
-        try internalConnection.subscribe(
-            method,
-            params: params,
-            updateClosure: updateClosure,
-            failureClosure: failureClosure
-        )
-    }
-
-    func cancelForIdentifier(_ identifier: UInt16) {
-        internalConnection.cancelForIdentifier(identifier)
-    }
-}
+// Use generated Cuckoo mock directly to conform to current JSONRPCEngine
+final class MockConnection: MockJSONRPCEngine {}

fearlessTests/Modules/ControllerAccount/ControllerAccountTests.swift

@@ -2,6 +2,7 @@ import XCTest
 import Cuckoo
 import RobinHood
 import SSFUtils
+import SSFModels
 import SoraKeystore
 import SoraFoundation
 @testable import fearless
@@ -52,14 +53,14 @@ class ControllerAccountTests: XCTestCase {
             when(stub).showConfirmation(
                 from: any(ControllerBackedProtocol?.self),
                 controllerAccountItem: any(fearless.ChainAccountResponse.self),
-                asset: any(AssetModel.self),
-                chain: any(ChainModel.self),
+                asset: any(SSFModels.AssetModel.self),
+                chain: any(SSFModels.ChainModel.self),
                 selectedAccount: any(fearless.MetaAccountModel.self)
             ).then { _ in
                 showConfirmationExpectation.fulfill()
             }
 
-            when(stub).present(viewModel: any(), from: any()).thenDoNothing()
+            when(stub).present(viewModel: any(SheetAlertPresentableViewModel.self), from: any(ControllerBackedProtocol?.self)).thenDoNothing()
         }
         stub(viewModelFactory) { stub in
             when(stub).createViewModel(
@@ -128,11 +129,11 @@ class ControllerAccountTests: XCTestCase {
         )
         stub(wireframe) { stub in
             when(stub).present(
-                message: any(String.self),
-                title: any(String?.self),
-                closeAction: any(String.self),
+                message: any(String?.self),
+                title: any(String.self),
+                closeAction: any(String?.self),
                 from: any(ControllerBackedProtocol?.self),
-                actions: any([UIAlertAction].self)
+                actions: any([SheetAlertPresentableAction].self)
             ).then { _ in
                 showErrorAlertExpectation.fulfill()
             }