Fix RSpec failure by using proper test recipe instead of converge_dsl

Co-authored-by: damacus <[email protected]>

Author: Copilot

spec/service_spec.rb

@@ -34,24 +34,23 @@
 
   # Test default behavior (no restart)
   context 'with default configuration' do
-    let(:chef_run) do
-      ChefSpec::ServerRunner.new(platform: 'ubuntu', version: '20.04', step_into: ['elasticsearch_service']) do |node, server|
-        node_resources(node)
-        stub_chef_zero('ubuntu', '20.04', server)
-      end.converge_dsl('test') do
-        elasticsearch_user 'elasticsearch'
-        elasticsearch_install 'elasticsearch' do
-          type 'package'
+    supported_platforms.each do |platform, versions|
+      versions.each do |version|
+        context "on #{platform.capitalize} #{version}" do
+          let(:chef_run) do
+            ChefSpec::ServerRunner.new(platform: platform, version: version, step_into: ['elasticsearch_service']) do |node, server|
+              node_resources(node)
+              stub_chef_zero(platform, version, server)
+            end.converge('test::default_service')
+          end
+
+          it 'creates systemd unit without restart policy' do
+            systemd_unit = chef_run.systemd_unit('elasticsearch')
+            expect(systemd_unit.content[:Service]).not_to have_key(:Restart)
+            expect(systemd_unit.content[:Service]).not_to have_key(:RestartSec)
+          end
         end
-        elasticsearch_configure 'elasticsearch'
-        elasticsearch_service 'elasticsearch'
       end
     end
-
-    it 'creates systemd unit without restart policy' do
-      systemd_unit = chef_run.systemd_unit('elasticsearch')
-      expect(systemd_unit.content[:Service]).not_to have_key(:Restart)
-      expect(systemd_unit.content[:Service]).not_to have_key(:RestartSec)
-    end
   end
 end

test/fixtures/cookbooks/test/recipes/default_service.rb

@@ -0,0 +1,18 @@
+# test fixture to validate default service configuration (no restart policy)
+
+# Basic installation and user setup
+elasticsearch_user 'elasticsearch'
+
+elasticsearch_install 'elasticsearch' do
+  type 'package'
+end
+
+elasticsearch_configure 'elasticsearch' do
+  allocated_memory '256m'
+  action :manage
+end
+
+# Test service with default configuration (no restart policy)
+elasticsearch_service 'elasticsearch' do
+  service_actions [:enable, :start]
+end