Add some default Sanitization to RichTextEntry (#6333)

* PR time

* am dum dont make PRs at 3am

* file scoped. I pushed this to the wrong branch initially because I'm stupid

* Revert "file scoped. I pushed this to the wrong branch initially because I'm stupid"

This reverts commit 9a911ca.

* Review

* Update API used by content to actually use the default values

---------

Co-authored-by: Princess Cheeseballs <[email protected]>

Author: Princess-Cheeseballs

Robust.Client/UserInterface/Controls/OutputPanel.cs

@@ -138,7 +138,7 @@ public void AddText(string text)
 
         public void AddMessage(FormattedMessage message)
         {
-            var entry = new RichTextEntry(message, this, _tagManager, null);
+            var entry = new RichTextEntry(message, this, _tagManager);
 
             entry.Update(_tagManager, _getFont(), _getContentBox().Width, UIScale);
 
@@ -153,7 +153,12 @@ public void AddMessage(FormattedMessage message)
             }
         }
 
-        public void SetMessage(Index index, FormattedMessage message, Type[]? tagsAllowed = null, Color? defaultColor = null)
+        public void SetMessage(Index index, FormattedMessage message, Color? defaultColor = null)
+        {
+            SetMessage(index, message, RichTextEntry.DefaultTags, defaultColor);
+        }
+
+        public void SetMessage(Index index, FormattedMessage message, Type[]? tagsAllowed, Color? defaultColor = null)
         {
             var atBottom = !_scrollDownButton.Visible;
             var oldEntry = _entries[index];

Robust.Client/UserInterface/Controls/RichTextLabel.cs

@@ -67,14 +67,24 @@ public RichTextLabel()
             VerticalAlignment = VAlignment.Center;
         }
 
-        public void SetMessage(FormattedMessage message, Type[]? tagsAllowed = null, Color? defaultColor = null)
+        public void SetMessage(FormattedMessage message, Color? defaultColor = null)
+        {
+            SetMessage(message, RichTextEntry.DefaultTags, defaultColor);
+        }
+
+        public void SetMessage(FormattedMessage message, Type[]? tagsAllowed, Color? defaultColor = null)
         {
             _entry?.RemoveControls();
             _entry = new RichTextEntry(message, this, _tagManager, tagsAllowed, defaultColor);
             InvalidateMeasure();
         }
 
-        public void SetMessage(string message, Type[]? tagsAllowed = null, Color? defaultColor = null)
+        public void SetMessage(string message, Color? defaultColor = null)
+        {
+            SetMessage(message, RichTextEntry.DefaultTags, defaultColor);
+        }
+
+        public void SetMessage(string message, Type[]? tagsAllowed, Color? defaultColor = null)
         {
             var msg = new FormattedMessage();
             msg.AddText(message);

Robust.Client/UserInterface/RichTextEntry.cs

@@ -19,6 +19,16 @@ namespace Robust.Client.UserInterface
     /// </summary>
     internal struct RichTextEntry
     {
+        public static readonly Type[] DefaultTags =
+        [
+            typeof(BoldItalicTag),
+            typeof(BoldTag),
+            typeof(BulletTag),
+            typeof(ColorTag),
+            typeof(HeadingTag),
+            typeof(ItalicTag)
+        ];
+
         private readonly Color _defaultColor;
         private readonly Type[]? _tagsAllowed;
 
@@ -41,17 +51,32 @@ internal struct RichTextEntry
 
         public readonly Dictionary<int, Control>? Controls;
 
-        public RichTextEntry(FormattedMessage message, Control parent, MarkupTagManager tagManager, Type[]? tagsAllowed = null, Color? defaultColor = null)
+
+        public RichTextEntry(
+            FormattedMessage message,
+            Control parent,
+            MarkupTagManager tagManager,
+            Color? defaultColor = null) : this(message, parent, tagManager, DefaultTags, defaultColor)
+        {
+            // RichTextEntry constructor but with DefaultTags
+        }
+
+        public RichTextEntry(FormattedMessage message, Control parent, MarkupTagManager tagManager, Type[]? tagsAllowed, Color? defaultColor = null)
         {
             Message = message;
             Height = 0;
             Width = 0;
             LineBreaks = default;
             _defaultColor = defaultColor ?? new(200, 200, 200);
             _tagsAllowed = tagsAllowed;
-            Dictionary<int, Control>? tagControls = null;
+            Controls = GetControls(parent, tagManager);
+        }
 
+        private readonly Dictionary<int, Control>? GetControls(Control parent, MarkupTagManager tagManager)
+        {
+            Dictionary<int, Control>? tagControls = null;
             var nodeIndex = -1;
+
             foreach (var node in Message)
             {
                 nodeIndex++;
@@ -71,7 +96,7 @@ public RichTextEntry(FormattedMessage message, Control parent, MarkupTagManager
                 tagControls.Add(nodeIndex, control);
             }
 
-            Controls = tagControls;
+            return tagControls;
         }
 
         // TODO RICH TEXT