fix: searchbnf.conf issue (#1860)

**Issue number:**

### PR Type

**What kind of change does this PR introduce?**
* [ ] Feature
* [x] Bug Fix
* [ ] Refactoring (no functional or API changes)
* [ ] Documentation Update
* [ ] Maintenance (dependency updates, CI, etc.)

## Summary

### Changes

Added a `-` in searchbnf_conf.template file, to fix the issue regarding
`searchbnf.conf`

### User experience

As the issue is fixed, users can now avail the search assistant for
their custom search command in Splunk UI.

## Checklist

If an item doesn't apply to your changes, leave it unchecked.

### Review

* [x] self-review - I have performed a self-review of this change
according to the [development
guidelines](https://splunk.github.io/addonfactory-ucc-generator/contributing/#development-guidelines)
* [ ] Changes are documented. The documentation is understandable,
examples work [(more
info)](https://splunk.github.io/addonfactory-ucc-generator/contributing/#documentation-guidelines)
* [x] PR title and description follows the [contributing
principles](https://splunk.github.io/addonfactory-ucc-generator/contributing/#pull-requests)
* [ ] meeting - I have scheduled a meeting or recorded a demo to explain
these changes (if there is a video, put a link below and in the ticket)

### Tests

See [the testing
doc](https://splunk.github.io/addonfactory-ucc-generator/contributing/#build-and-test).

* [x] Unit - tests have been added/modified to cover the changes
* [ ] Smoke - tests have been added/modified to cover the changes
* [ ] UI - tests have been added/modified to cover the changes
* [x] coverage - I have checked the code coverage of my changes [(see
more)](https://splunk.github.io/addonfactory-ucc-generator/contributing/#checking-the-code-coverage)

**Demo/meeting:**

*Reviewers are encouraged to request meetings or demos if any part of
the change is unclear*

Author: hetangmodi-crest

docs/custom_search_commands.md

@@ -68,7 +68,7 @@ python.version = python3
 
 To generate a custom search command, the following attributes must be defined in globalConfig: `commandName`, `commandType`, `fileName`, and `arguments`. Based on the provided commandType, UCC will generate a template Python file and integrate the user-defined logic into it.
 
-If `requiredSearchAssistant` is set to True, the `syntax`, `description`, and `usage` attributes are mandatory, as they are essential for generating `searchbnf.conf` file.
+If `requiredSearchAssistant` is set to True, the `syntax`, `description`, and `usage` attributes are mandatory, as they are essential for generating `searchbnf.conf`. For more information about these attributes please refer to the [searchbnf.conf docs](https://docs.splunk.com/Documentation/Splunk/9.4.2/Admin/Searchbnfconf)
 
 **NOTE:**
     The user-defined Python file must include specific functions based on the command type:

splunk_add_on_ucc_framework/templates/conf_files/searchbnf_conf.template

@@ -1,5 +1,5 @@
 {% for info in searchbnf_info -%}
-[{{info["command_name"]}}]
+[{{info["command_name"]}}-command]
 syntax = {{info["syntax"]}}
 description = {{info["description"]}}
 usage = {{info["usage"]}}

tests/testdata/expected_addons/expected_output_global_config_everything/Splunk_TA_UCCExample/bin/filtercommand.py

@@ -10,10 +10,10 @@ class FiltercommandCommand(EventingCommand):
     """
 
     ##Syntax
-    | filtercommand contains='value1' replace='value to be replaced,value to replace with'
+    filtercommand contains=<string> replace=<string>
 
     ##Description
-    It filters records from the events stream returning only those which has :code:`contains` in them and replaces :code:`replace_array[0]` with :code:`replace_array[1]`.
+    Filters records from the events stream.
 
     """
 

tests/testdata/expected_addons/expected_output_global_config_everything/Splunk_TA_UCCExample/default/searchbnf.conf

@@ -1,9 +1,9 @@
-[generatetextcommand]
+[generatetextcommand-command]
 syntax = generatetextcommand count=<event_count> text=<string>
 description = This command generates COUNT occurrences of a TEXT string.
 usage = public
 
-[filtercommand]
-syntax = | filtercommand contains='value1' replace='value to be replaced,value to replace with'
-description = It filters records from the events stream returning only those which has :code:`contains` in them and replaces :code:`replace_array[0]` with :code:`replace_array[1]`.
+[filtercommand-command]
+syntax = filtercommand contains=<string> replace=<string>
+description = Filters records from the events stream.
 usage = public

tests/testdata/test_addons/package_global_config_everything/globalConfig.json

@@ -2403,7 +2403,7 @@
     "meta": {
         "name": "Splunk_TA_UCCExample",
         "restRoot": "splunk_ta_uccexample",
-        "version": "5.67.0+f5921d36e",
+        "version": "5.69.0+d6b58f8c0",
         "displayName": "Splunk UCC test Add-on",
         "schemaVersion": "0.0.9",
         "supportedThemes": [
@@ -2469,8 +2469,8 @@
             "fileName": "filter.py",
             "commandType": "dataset processing",
             "requiredSearchAssistant": true,
-            "description": "It filters records from the events stream returning only those which has :code:`contains` in them and replaces :code:`replace_array[0]` with :code:`replace_array[1]`.",
-            "syntax": "| filtercommand contains='value1' replace='value to be replaced,value to replace with'",
+            "description": "Filters records from the events stream.",
+            "syntax": "filtercommand contains=<string> replace=<string>",
             "usage": "public",
             "arguments": [
                 {

tests/unit/generators/conf_files/test_create_searchbnf_conf.py

@@ -92,7 +92,7 @@ def test_generate_conf(global_config_all_json, input_dir, output_dir):
     exp_fname = "searchbnf.conf"
     expected_content = dedent(
         """
-        [generatetextcommand]
+        [generatetextcommand-command]
         syntax = generatetextcommand count=<event_count> text=<string>
         description = This command generates COUNT occurrences of a TEXT string.
         usage = public