Fix missing JobParameters propagation in MetaDataInstanceFactory.createStepExecution

Resolves #5115

Signed-off-by: Sanghyuk Jung <[email protected]>

Author: benelog

spring-batch-test/src/main/java/org/springframework/batch/test/MetaDataInstanceFactory.java

@@ -189,7 +189,7 @@ public static StepExecution createStepExecution(JobParameters jobParameters, Exe
 	public static StepExecution createStepExecution(JobParameters jobParameters) {
 		JobExecution jobExecution = createJobExecution(DEFAULT_JOB_NAME, DEFAULT_JOB_INSTANCE_ID,
 				DEFAULT_JOB_EXECUTION_ID, jobParameters);
-		StepExecution stepExecution = createStepExecution();
+		StepExecution stepExecution = createStepExecution(jobExecution, DEFAULT_STEP_NAME, DEFAULT_STEP_EXECUTION_ID);
 		jobExecution.addStepExecution(stepExecution);
 		return stepExecution;
 	}

spring-batch-test/src/test/java/org/springframework/batch/test/MetaDataInstanceFactoryTests.java

@@ -15,13 +15,16 @@
  */
 package org.springframework.batch.test;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 
 import java.util.List;
 
 import org.junit.jupiter.api.Test;
 import org.springframework.batch.core.job.parameters.JobParameters;
 import org.springframework.batch.core.converter.DefaultJobParametersConverter;
+import org.springframework.batch.core.job.parameters.JobParametersBuilder;
+import org.springframework.batch.core.step.StepExecution;
 import org.springframework.batch.infrastructure.support.PropertiesConverter;
 
 /**
@@ -37,7 +40,7 @@ class MetaDataInstanceFactoryTests {
 	private final String jobParametersString = "foo=bar";
 
 	private final JobParameters jobParameters = new DefaultJobParametersConverter()
-		.getJobParameters(PropertiesConverter.stringToProperties(jobParametersString));
+			.getJobParameters(PropertiesConverter.stringToProperties(jobParametersString));
 
 	private final Long executionId = 4321L;
 
@@ -90,6 +93,14 @@ void testCreateStepExecutionJobExecutionStringLong() {
 		assertNotNull(MetaDataInstanceFactory.createStepExecution(stepName, stepExecutionId));
 	}
 
+	@Test
+	void testCreateStepExecutionJobParameters() {
+		JobParameters parameters = new JobParametersBuilder().addString("foo", "bar").toJobParameters();
+		StepExecution stepExecution = MetaDataInstanceFactory.createStepExecution(parameters);
+		String paramValue = stepExecution.getJobExecution().getJobParameters().getString("foo");
+		assertEquals("bar", paramValue);
+	}
+
 	@Test
 	void testCreateJobExecutionWithStepExecutions() {
 		assertNotNull(MetaDataInstanceFactory.createJobExecutionWithStepExecutions(executionId, List.of(stepName)));