[FEAT] allow price rounding between 0 and 4 digits (OpenMage#4701)

* [FEAT] allow price rounding between 0 and 4 digits

* Update app/code/core/Mage/Catalog/Helper/Price.php

* Update app/code/core/Mage/Catalog/Helper/Price.php

* Update app/code/core/Mage/Catalog/etc/system.xml

* Update app/code/core/Mage/Catalog/Helper/Price.php

Co-authored-by: Copilot <[email protected]>

* Update app/code/core/Mage/Catalog/Helper/Price.php

Co-authored-by: Copilot <[email protected]>

* Update app/code/core/Mage/Core/Model/Store.php

Co-authored-by: Copilot <[email protected]>

* Update app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Price.php

Co-authored-by: Copilot <[email protected]>

* declare strict, rector, copyright

---------

Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Copilot <[email protected]>

Author: 3 people

app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Price.php

@@ -79,6 +79,9 @@ public function getEscapedValue($index = null)
             return null;
         }
 
-        return number_format((float) $value, 2, null, '');
+        /** @var Mage_Catalog_Helper_Price $helper */
+        $helper = Mage::helper('catalog/price');
+
+        return number_format((float) $value, $helper->getRoundingPrecision(), null, '');
     }
 }

app/code/core/Mage/Catalog/Helper/Price.php

@@ -0,0 +1,43 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * @copyright  For copyright and license information, read the COPYING.txt file.
+ * @link       /COPYING.txt
+ * @license    Open Software License (OSL 3.0)
+ * @package    Mage_Catalog
+ */
+
+/**
+ * Catalog price helper
+ *
+ * @category   Mage
+ * @package    Mage_Catalog
+ */
+class Mage_Catalog_Helper_Price extends Mage_Core_Helper_Abstract
+{
+    public const XML_PATH_ROUNDING_PRECISION    = 'catalog/price/rounding_precision';
+
+    public const ROUNDING_PRECISION_DEFAULT     = 2;
+
+    public const ROUNDING_PRECISION_MAX         = 4;
+
+    public const ROUNDING_PRECISION_MIN         = 0;
+
+    protected $_moduleName = 'Mage_Catalog';
+
+    /**
+     * @SuppressWarnings("PHPMD.StaticAccess")
+     */
+    public function getRoundingPrecision(): int
+    {
+        /** @var int<0,4> $precision */
+        $precision = Mage::getStoreConfigAsInt(self::XML_PATH_ROUNDING_PRECISION);
+        if ($precision < self::ROUNDING_PRECISION_MIN || $precision > self::ROUNDING_PRECISION_MAX) {
+            return self::ROUNDING_PRECISION_DEFAULT;
+        }
+
+        return $precision;
+    }
+}

app/code/core/Mage/Catalog/etc/config.xml

@@ -803,6 +803,9 @@
             <product>
                 <default_tax_group>2</default_tax_group>
             </product>
+            <price>
+                <rounding_precision>2</rounding_precision>
+            </price>
             <product_image>
                 <base_width>1800</base_width>
                 <small_width>210</small_width>

app/code/core/Mage/Catalog/etc/system.xml

@@ -318,6 +318,16 @@
                             <show_in_website>0</show_in_website>
                             <show_in_store>0</show_in_store>
                         </scope>
+                        <rounding_precision translate="label comment">
+                            <comment><![CDATA[0, 1, 2, 3, 4]]>.</comment>
+                            <label>Catalog Price Rounding Precision</label>
+                            <frontend_type>text</frontend_type>
+                            <sort_order>2</sort_order>
+                            <show_in_default>1</show_in_default>
+                            <show_in_website>0</show_in_website>
+                            <show_in_store>0</show_in_store>
+                            <validate>required-entry validate-number-range number-range-0-4</validate>
+                        </rounding_precision>
                     </fields>
                 </price>
                 <layered_navigation translate="label">

app/code/core/Mage/Core/Model/Store.php

@@ -1011,7 +1011,10 @@ public function convertPrice($price, $format = false, $includeContainer = true)
      */
     public function roundPrice($price)
     {
-        return round((float) $price, 2);
+        /** @var Mage_Catalog_Helper_Price $helper */
+        $helper = Mage::helper('catalog/price');
+
+        return round((float) $price, $helper->getRoundingPrecision());
     }
 
     /**