rector: CountArrayToEmptyArrayComparisonRector (OpenMage#4998)

* rector: `CountArrayToEmptyArrayComparisonRector`

* phpStan

Author: sreichel

.phpstan.dist.baseline.neon

@@ -4902,6 +4902,12 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Tax/Model/Resource/Calculation/Rate/Title/Collection.php
 
+		-
+			rawMessage: 'Strict comparison using === between non-empty-list and array{} will always evaluate to false.'
+			identifier: identical.alwaysFalse
+			count: 1
+			path: app/code/core/Mage/Tax/Model/Resource/Setup.php
+
 		-
 			rawMessage: 'Parameter #2 $rate of method Mage_Tax_Model_Sales_Total_Quote_Shipping::_round() expects string, float given.'
 			identifier: argument.type

.rector.php

@@ -79,7 +79,6 @@
             CodingStyle\Encapsed\EncapsedStringsToSprintfRector::class, # todo: TMP
             CodingStyle\Encapsed\WrapEncapsedVariableInCurlyBracesRector::class, # todo: TMP
             CodingStyle\FuncCall\CallUserFuncArrayToVariadicRector::class, # todo: TMP
-            CodingStyle\FuncCall\CountArrayToEmptyArrayComparisonRector::class, # todo: TMP
             CodingStyle\FuncCall\StrictArraySearchRector::class, # todo: TMP
             CodingStyle\If_\NullableCompareToNullRector::class, # todo: TMP
             CodingStyle\PostInc\PostIncDecToPreIncDecRector::class, # todo: TMP

app/code/core/Mage/Admin/Model/Resource/Block.php

@@ -57,7 +57,7 @@ protected function _generateCache()
         $collection->addFieldToFilter('is_allowed', ['eq' => 1]);
 
         $disallowedBlockNames = $this->getDisallowedBlockNames();
-        if (is_array($disallowedBlockNames) && count($disallowedBlockNames) > 0) {
+        if (is_array($disallowedBlockNames) && $disallowedBlockNames !== []) {
             $collection->addFieldToFilter('block_name', ['nin' => $disallowedBlockNames]);
         }
 

app/code/core/Mage/Admin/Model/User.php

@@ -259,7 +259,7 @@ public function deleteFromRole()
     public function roleUserExists()
     {
         $result = $this->_getResource()->roleUserExists($this);
-        return is_array($result) && count($result) > 0;
+        return is_array($result) && $result !== [];
     }
 
     /**
@@ -281,7 +281,7 @@ public function add()
     public function userExists()
     {
         $result = $this->_getResource()->userExists($this);
-        return is_array($result) && count($result) > 0;
+        return is_array($result) && $result !== [];
     }
 
     /**

app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Billing/Method/Form.php

@@ -80,7 +80,7 @@ public function hasSsCardType()
     {
         $availableTypes = explode(',', $this->getQuote()->getPayment()->getMethod()->getConfigData('cctypes'));
         $ssPresenations = array_intersect(['SS', 'SM', 'SO'], $availableTypes);
-        if ($availableTypes && count($ssPresenations) > 0) {
+        if ($availableTypes && $ssPresenations !== []) {
             return true;
         }
 

app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage.php

@@ -55,7 +55,7 @@ public function getItems()
             }
         }
 
-        if (count($items)) {
+        if ($items !== []) {
             return $items;
         }
 

app/code/core/Mage/Adminhtml/controllers/Newsletter/ProblemController.php

@@ -49,7 +49,7 @@ public function gridAction()
     {
         if ($this->getRequest()->getParam('_unsubscribe')) {
             $problems = (array) $this->getRequest()->getParam('problem', []);
-            if (count($problems) > 0) {
+            if ($problems !== []) {
                 $collection = Mage::getResourceModel('newsletter/problem_collection');
                 $collection
                     ->addSubscriberInfo()
@@ -68,7 +68,7 @@ public function gridAction()
 
         if ($this->getRequest()->getParam('_delete')) {
             $problems = (array) $this->getRequest()->getParam('problem', []);
-            if (count($problems) > 0) {
+            if ($problems !== []) {
                 $collection = Mage::getResourceModel('newsletter/problem_collection');
                 $collection
                     ->addFieldToFilter(

app/code/core/Mage/Adminhtml/controllers/Tax/RuleController.php

@@ -149,7 +149,7 @@ protected function _isValidRuleRequest($ruleModel)
         $existingRules = array_diff($existingRules, [$ruleModel->getOrigData('code')]);
 
         //Verify if a Rule already exists. If not throw an error
-        if (count($existingRules) > 0) {
+        if ($existingRules !== []) {
             $ruleCodes = implode(',', $existingRules);
             $session->addError(
                 $this->_getHelperModel('tax')->__('Rules (%s) already exist for the specified Tax Rate, Customer Tax Class and Product Tax Class combinations', $ruleCodes),

app/code/core/Mage/Api/Helper/Data.php

@@ -130,7 +130,7 @@ public function associativeArrayUnpack(&$mixed)
                 }
             }
 
-            if (count($tmpArr)) {
+            if ($tmpArr !== []) {
                 $mixed = $tmpArr;
             }
         }

app/code/core/Mage/Api/Model/User.php

@@ -156,7 +156,7 @@ public function deleteFromRole()
     public function roleUserExists()
     {
         $result = $this->_getResource()->roleUserExists($this);
-        return is_array($result) && count($result) > 0;
+        return is_array($result) && $result !== [];
     }
 
     /**
@@ -178,7 +178,7 @@ public function add()
     public function userExists()
     {
         $result = $this->_getResource()->userExists($this);
-        return is_array($result) && count($result) > 0;
+        return is_array($result) && $result !== [];
     }
 
     /**