Fix unserializeArray on nonserialized string (OpenMage#4387)

* fix unserializeArray on nonserialized string

* ~ use isSerializedArrayOrObject

---------

Co-authored-by: Sven Reichel <[email protected]>

Author: Hanmac

app/code/core/Mage/Sales/Model/Quote/Item.php

@@ -516,12 +516,16 @@ public function compare($item)
                 // dispose of some options params, that can cramp comparing of arrays
                 if (is_string($itemOptionValue) && is_string($optionValue)) {
                     try {
-                        /** @var Unserialize_Parser $parser */
+                        /**
+                         * @var Mage_Core_Helper_UnserializeArray $parser
+                         * @var Mage_Core_Helper_String $stringHelper
+                         */
                         $parser = Mage::helper('core/unserializeArray');
+                        $stringHelper = Mage::helper('core/string');
 
-                        $_itemOptionValue =
-                            is_numeric($itemOptionValue) ? $itemOptionValue : $parser->unserialize($itemOptionValue);
-                        $_optionValue = is_numeric($optionValue) ? $optionValue : $parser->unserialize($optionValue);
+                        // only ever try to unserialize, if it looks like a serialized array
+                        $_itemOptionValue = $stringHelper->isSerializedArrayOrObject($itemOptionValue) ? $parser->unserialize($itemOptionValue) : $itemOptionValue;
+                        $_optionValue = $stringHelper->isSerializedArrayOrObject($optionValue) ? $parser->unserialize($optionValue) : $optionValue;
 
                         if (is_array($_itemOptionValue) && is_array($_optionValue)) {
                             $itemOptionValue = $_itemOptionValue;