Fix Possible Array Access warnings in Captcha Observer (OpenMage#4424)

Hanmac · web-flow · commit c9a901f39232 · 2024-12-19T08:52:52.000+01:00
diff --git a/app/code/core/Mage/Captcha/Model/Observer.php b/app/code/core/Mage/Captcha/Model/Observer.php
@@ -274,7 +274,7 @@ protected function _resetAttempt($login)
     protected function _getCaptchaString($request, $formId)
     {
         $captchaParams = $request->getPost(Mage_Captcha_Helper_Data::INPUT_NAME_FIELD_VALUE);
-        return $captchaParams[$formId];
+        return $captchaParams[$formId] ?? '';
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -274,7 +274,7 @@ protected function _resetAttempt($login)`
`274`	`274`	`protected function _getCaptchaString($request, $formId)`
`275`	`275`	`{`
`276`	`276`	`$captchaParams = $request->getPost(Mage_Captcha_Helper_Data::INPUT_NAME_FIELD_VALUE);`
`277`		`- return $captchaParams[$formId];`
	`277`	`+ return $captchaParams[$formId] ?? '';`
`278`	`278`	`}`
`279`	`279`
`280`	`280`	`/**`