Bump phpstan/phpstan from 1.10.67 to 1.11.2 (#9)

dependabot[bot] · sreichel · web-flow · commit cea740b4fab7 · 2024-05-29T03:28:09.000+02:00
* Bump phpstan/phpstan from 1.10.67 to 1.11.2 Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.10.67 to 1.11.2. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md) - [Commits](phpstan/phpstan@1.10.67...1.11.2) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Fixes phpstan --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sven Reichel <github-sr@hotmail.com>
diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Ajax/Serializer.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Ajax/Serializer.php
@@ -19,6 +19,9 @@
  */
 class Mage_Adminhtml_Block_Catalog_Product_Edit_Tab_Ajax_Serializer extends Mage_Core_Block_Template
 {
+    /**
+     * @return $this
+     */
     public function _construct()
     {
         parent::_construct();
diff --git a/app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php b/app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php
@@ -633,7 +633,7 @@ public function getOrderOptions($product = null)
      * Save type related data
      *
      * @param Mage_Catalog_Model_Product $product
-     * @return Mage_Catalog_Model_Product_Type_Abstract
+     * @return $this
      */
     public function save($product = null)
     {
diff --git a/app/code/core/Mage/CatalogIndex/Model/Indexer/Eav.php b/app/code/core/Mage/CatalogIndex/Model/Indexer/Eav.php
@@ -34,7 +34,7 @@ class Mage_CatalogIndex_Model_Indexer_Eav extends Mage_CatalogIndex_Model_Indexe
     protected function _construct()
     {
         $this->_init('catalogindex/indexer_eav');
-        return parent::_construct();
+        parent::_construct();
     }
 
     /**
diff --git a/app/code/core/Mage/CatalogIndex/Model/Indexer/Minimalprice.php b/app/code/core/Mage/CatalogIndex/Model/Indexer/Minimalprice.php
@@ -54,7 +54,7 @@ protected function _construct()
         $this->_currencyModel = Mage::getModel('directory/currency');
         $this->_customerGroups = Mage::getModel('customer/group')->getCollection();
 
-        return parent::_construct();
+        parent::_construct();
     }
 
     /**
diff --git a/app/code/core/Mage/CatalogIndex/Model/Indexer/Tierprice.php b/app/code/core/Mage/CatalogIndex/Model/Indexer/Tierprice.php
@@ -60,7 +60,7 @@ protected function _construct()
         $this->_currencyModel = Mage::getModel('directory/currency');
         $this->_customerGroups = Mage::getModel('customer/group')->getCollection();
 
-        return parent::_construct();
+        parent::_construct();
     }
 
     /**
diff --git a/app/code/core/Mage/Core/Controller/Varien/Action.php b/app/code/core/Mage/Core/Controller/Varien/Action.php
@@ -130,6 +130,9 @@ public function __construct(Zend_Controller_Request_Abstract $request, Zend_Cont
         $this->_construct();
     }
 
+    /**
+     * @return void
+     */
     protected function _construct()
     {
     }
diff --git a/app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php b/app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php
@@ -125,6 +125,7 @@ public function __construct($resource = null)
     /**
      * Initialization here
      *
+     * @return void
      */
     protected function _construct()
     {
diff --git a/app/code/core/Mage/Paypal/Block/Express/Form.php b/app/code/core/Mage/Paypal/Block/Express/Form.php
@@ -32,9 +32,8 @@ class Mage_Paypal_Block_Express_Form extends Mage_Paypal_Block_Standard_Form
      */
     protected function _construct()
     {
-        $result = parent::_construct();
+        parent::_construct();
         $this->setRedirectMessage(Mage::helper('paypal')->__('You will be redirected to the PayPal website.'));
-        return $result;
     }
 
     /**
diff --git a/app/code/core/Mage/Paypal/Block/Standard/Form.php b/app/code/core/Mage/Paypal/Block/Standard/Form.php
@@ -54,7 +54,7 @@ protected function _construct()
             ->setMethodTitle('') // Output PayPal mark, omit title
             ->setMethodLabelAfterHtml($mark->toHtml())
         ;
-        return parent::_construct();
+        parent::_construct();
     }
 
     /**
diff --git a/app/code/core/Mage/Paypal/Model/Payment/Transaction.php b/app/code/core/Mage/Paypal/Model/Payment/Transaction.php
@@ -60,7 +60,7 @@ class Mage_Paypal_Model_Payment_Transaction extends Mage_Core_Model_Abstract
     protected function _construct()
     {
         $this->_init('paypal/payment_transaction');
-        return parent::_construct();
+        parent::_construct();
     }
 
     /**
diff --git a/app/code/core/Mage/Sales/Block/Adminhtml/Recurring/Profile/Edit/Form.php b/app/code/core/Mage/Sales/Block/Adminhtml/Recurring/Profile/Edit/Form.php
@@ -79,7 +79,7 @@ public function setProductEntity(Mage_Catalog_Model_Product $product)
     protected function _construct()
     {
         $this->_profile = Mage::getSingleton('sales/recurring_profile');
-        return parent::_construct();
+        parent::_construct();
     }
 
     /**
diff --git a/app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php b/app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php
@@ -130,7 +130,7 @@ class Mage_Sales_Model_Order_Payment_Transaction extends Mage_Core_Model_Abstrac
     protected function _construct()
     {
         $this->_init('sales/order_payment_transaction');
-        return parent::_construct();
+        parent::_construct();
     }
 
     /**
diff --git a/app/code/core/Mage/Widget/Model/Resource/Widget/Instance/Collection.php b/app/code/core/Mage/Widget/Model/Resource/Widget/Instance/Collection.php
@@ -22,7 +22,7 @@
 class Mage_Widget_Model_Resource_Widget_Instance_Collection extends Mage_Core_Model_Resource_Db_Collection_Abstract
 {
     /**
-     * Fields map for corellation names & real selected fields
+     * Fields map for correlation names & real selected fields
      *
      * @var array
      */
diff --git a/composer.lock b/composer.lock
diff --git a/lib/Varien/Object.php b/lib/Varien/Object.php
@@ -131,6 +131,8 @@ protected function _prepareSyncFieldsMap()
 
     /**
      * Internal constructor not depended on params. Can be used for object initialization
+     *
+     * @return void
      */
     protected function _construct()
     {

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,9 @@`
`19`	`19`	`*/`
`20`	`20`	`class Mage_Adminhtml_Block_Catalog_Product_Edit_Tab_Ajax_Serializer extends Mage_Core_Block_Template`
`21`	`21`	`{`
	`22`	`+ /**`
	`23`	`+ * @return $this`
	`24`	`+ */`
`22`	`25`	`public function _construct()`
`23`	`26`	`{`
`24`	`27`	`parent::_construct();`
Original file line number	Diff line number	Diff line change
`@@ -633,7 +633,7 @@ public function getOrderOptions($product = null)`
`633`	`633`	`* Save type related data`
`634`	`634`	`*`
`635`	`635`	`* @param Mage_Catalog_Model_Product $product`
`636`		`- * @return Mage_Catalog_Model_Product_Type_Abstract`
	`636`	`+ * @return $this`
`637`	`637`	`*/`
`638`	`638`	`public function save($product = null)`
`639`	`639`	`{`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ class Mage_CatalogIndex_Model_Indexer_Eav extends Mage_CatalogIndex_Model_Indexe`
`34`	`34`	`protected function _construct()`
`35`	`35`	`{`
`36`	`36`	`$this->_init('catalogindex/indexer_eav');`
`37`		`- return parent::_construct();`
	`37`	`+ parent::_construct();`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ protected function _construct()`
`54`	`54`	`$this->_currencyModel = Mage::getModel('directory/currency');`
`55`	`55`	`$this->_customerGroups = Mage::getModel('customer/group')->getCollection();`
`56`	`56`
`57`		`- return parent::_construct();`
	`57`	`+ parent::_construct();`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ protected function _construct()`
`60`	`60`	`$this->_currencyModel = Mage::getModel('directory/currency');`
`61`	`61`	`$this->_customerGroups = Mage::getModel('customer/group')->getCollection();`
`62`	`62`
`63`		`- return parent::_construct();`
	`63`	`+ parent::_construct();`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -130,6 +130,9 @@ public function __construct(Zend_Controller_Request_Abstract $request, Zend_Cont`
`130`	`130`	`$this->_construct();`
`131`	`131`	`}`
`132`	`132`
	`133`	`+ /**`
	`134`	`+ * @return void`
	`135`	`+ */`
`133`	`136`	`protected function _construct()`
`134`	`137`	`{`
`135`	`138`	`}`
Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,7 @@ public function __construct($resource = null)`
`125`	`125`	`/**`
`126`	`126`	`* Initialization here`
`127`	`127`	`*`
	`128`	`+ * @return void`
`128`	`129`	`*/`
`129`	`130`	`protected function _construct()`
`130`	`131`	`{`
Original file line number	Diff line number	Diff line change
`@@ -32,9 +32,8 @@ class Mage_Paypal_Block_Express_Form extends Mage_Paypal_Block_Standard_Form`
`32`	`32`	`*/`
`33`	`33`	`protected function _construct()`
`34`	`34`	`{`
`35`		`- $result = parent::_construct();`
	`35`	`+ parent::_construct();`
`36`	`36`	`$this->setRedirectMessage(Mage::helper('paypal')->__('You will be redirected to the PayPal website.'));`
`37`		`- return $result;`
`38`	`37`	`}`
`39`	`38`
`40`	`39`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ class Mage_Paypal_Model_Payment_Transaction extends Mage_Core_Model_Abstract`
`60`	`60`	`protected function _construct()`
`61`	`61`	`{`
`62`	`62`	`$this->_init('paypal/payment_transaction');`
`63`		`- return parent::_construct();`
	`63`	`+ parent::_construct();`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`/**`