PhpStan: add install files to checks (OpenMage#5029)

* DOCblock fixes

* re-added data files

* DOCblock

Author: sreichel

.phpstan.dist.neon

@@ -61,10 +61,6 @@ parameters:
         # Dataflow/Model/Convert/Iterator.php
         - app/code/core/Mage/Dataflow/Model/Convert/Iterator.php
 
-        # Too much noise from "Variable $this might not be defined"
-        - app/code/core/*/*/data/*
-        - app/code/core/*/*/sql/*
-
         # requires Mycrypt
         - lib/Magento/Crypt.php
         - lib/Varien/Crypt/Mcrypt.php

app/code/core/Mage/Admin/sql/admin_setup/install-1.6.0.0.php

@@ -7,7 +7,7 @@
  * @package    Mage_Admin
  */
 
-/** @var Mage_Core_Model_Resource_Setup $installer */
+/** @var Mage_Core_Model_Resource_Setup $this */
 $installer = $this;
 $installer->startSetup();
 

app/code/core/Mage/Admin/sql/admin_setup/upgrade-1.6.0.0-1.6.1.0.php

@@ -7,7 +7,7 @@
  * @package    Mage_Admin
  */
 
-/** @var Mage_Core_Model_Resource_Setup $installer */
+/** @var Mage_Core_Model_Resource_Setup $this */
 $installer = $this;
 $installer->startSetup();
 

app/code/core/Mage/Admin/sql/admin_setup/upgrade-1.6.1.0-1.6.1.1.php

@@ -7,7 +7,7 @@
  * @package    Mage_Admin
  */
 
-/** @var Mage_Core_Model_Resource_Setup $installer */
+/** @var Mage_Core_Model_Resource_Setup $this */
 $installer = $this;
 $installer->startSetup();
 

app/code/core/Mage/Admin/sql/admin_setup/upgrade-1.6.1.1-1.6.1.2.php

@@ -7,7 +7,7 @@
  * @package    Mage_Admin
  */
 
-/** @var Mage_Core_Model_Resource_Setup $installer */
+/** @var Mage_Core_Model_Resource_Setup $this */
 $installer = $this;
 $installer->startSetup();
 

app/code/core/Mage/Admin/sql/admin_setup/upgrade-1.6.1.2-1.6.1.3.php

@@ -7,7 +7,7 @@
  * @package    Mage_Admin
  */
 
-/** @var Mage_Core_Model_Resource_Setup $installer */
+/** @var Mage_Core_Model_Resource_Setup $this */
 $installer = $this;
 $installer->startSetup();
 

app/code/core/Mage/Admin/sql/admin_setup/upgrade-1.6.1.3-1.6.1.4.php

@@ -7,7 +7,7 @@
  * @package    Mage_Admin
  */
 
-/** @var Mage_Core_Model_Resource_Setup $installer */
+/** @var Mage_Core_Model_Resource_Setup $this */
 $installer = $this;
 $installer->startSetup();
 

app/code/core/Mage/Admin/sql/admin_setup/upgrade-1.6.1.4-1.6.1.5.php

@@ -7,7 +7,7 @@
  * @package    Mage_Admin
  */
 
-/** @var Mage_Core_Model_Resource_Setup $installer */
+/** @var Mage_Core_Model_Resource_Setup $this */
 $installer = $this;
 $installer->startSetup();
 

app/code/core/Mage/AdminNotification/sql/adminnotification_setup/install-1.6.0.0.php

@@ -7,7 +7,7 @@
  * @package    Mage_AdminNotification
  */
 
-/** @var Mage_Core_Model_Resource_Setup $installer */
+/** @var Mage_Core_Model_Resource_Setup $this */
 $installer = $this;
 $installer->startSetup();
 /**

app/code/core/Mage/Api/sql/api_setup/install-1.6.0.0.php

@@ -7,7 +7,7 @@
  * @package    Mage_Api
  */
 
-/** @var Mage_Core_Model_Resource_Setup $installer */
+/** @var Mage_Core_Model_Resource_Setup $this */
 $installer = $this;
 $installer->startSetup();