php 8.3: fix catch for empty sitemap filename (OpenMage#4521)

midlan · web-flow · commit e5feff0384a4 · 2025-02-01T07:54:19.000+01:00
diff --git a/app/code/core/Mage/Sitemap/Model/Observer.php b/app/code/core/Mage/Sitemap/Model/Observer.php
@@ -68,7 +68,7 @@ public function scheduledGenerateSitemaps($schedule)
 
             try {
                 $sitemap->generateXml();
-            } catch (Exception $e) {
+            } catch (Throwable $e) {
                 $errors[] = $e->getMessage();
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ public function scheduledGenerateSitemaps($schedule)`
`68`	`68`
`69`	`69`	`try {`
`70`	`70`	`$sitemap->generateXml();`
`71`		`- } catch (Exception $e) {`
	`71`	`+ } catch (Throwable $e) {`
`72`	`72`	`$errors[] = $e->getMessage();`
`73`	`73`	`}`
`74`	`74`	`}`