Ensured html decoding of og:image urls

ssddanbrown · ssddanbrown · commit a144c252ebbf · 2022-07-07T16:26:29.000+01:00
Related to #5
diff --git a/app/Rss/PostThumbnailFetcher.php b/app/Rss/PostThumbnailFetcher.php
@@ -79,7 +79,7 @@ protected function getThumbLinkFromUrl(string $url): string
             return '';
         }
 
-        $link = $linkMatches[1];
+        $link = html_entity_decode($linkMatches[1]);
 
         if (!str_starts_with($link, 'https://') && !str_starts_with($link, 'http://')) {
             return '';
diff --git a/tests/Feature/PostThumbnailFetcherTest.php b/tests/Feature/PostThumbnailFetcherTest.php
@@ -40,4 +40,28 @@ public function test_successful_fetch()
 
         unlink($expectedPath);
     }
+
+    public function test_html_encoding_in_opengraph_url_is_decoded()
+    {
+        $imageData = base64_decode('iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACklEQVR4nGMAAQAABQABDQottAAAAABJRU5ErkJggg==');
+        Http::fake([
+            'example.com/*' => Http::response(<<<END
+<html>
+<head>
+<meta property="og:image" content="https://exampleb.com/image.png?a=b&amp;c=d">
+</head>
+</html>
+END),
+            'https://exampleb.com/image.png?a=b&c=d' => Http::response($imageData),
+            'exampleb.com/*' => Http::response('', 404),
+        ]);
+        $post = Post::factory()->create(['url' => 'http://example.com/cats']);
+
+        $fetcher = new PostThumbnailFetcher();
+        $result = $fetcher->fetchAndStoreForPost($post);
+        $this->assertTrue($result);
+
+        $expectedPath = storage_path("app/public/thumbs/{$post->feed_id}/{$post->id}.png");
+        unlink($expectedPath);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ protected function getThumbLinkFromUrl(string $url): string`
`79`	`79`	`return '';`
`80`	`80`	`}`
`81`	`81`
`82`		`- $link = $linkMatches[1];`
	`82`	`+ $link = html_entity_decode($linkMatches[1]);`
`83`	`83`
`84`	`84`	`if (!str_starts_with($link, 'https://') && !str_starts_with($link, 'http://')) {`
`85`	`85`	`return '';`