Skip to content

Commit 112fc3e

Browse files
duncanmccleanjesseleitejasonvarga
authored
PHP 8.4 Support (#120)
* wip * Kick test suite. * back to original constraint * bump * fix missing quote * We can do without this. * Require Statamic 5.41 * take away php 8.4 for a second * wip * wip * could some of the php 8.4 fixes in newer versions of php cs fixer help? * maybe try the absolute latest version then * wip * wip * put everything back to how it was * use current testbench versions to see if that fixes the tests * ah, we need these versions of testbench * require minimum version of PHP CS Fixer for PHP 8.4 support --------- Co-authored-by: Jesse Leite <[email protected]> Co-authored-by: Jason Varga <[email protected]>
1 parent 700a08e commit 112fc3e

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

.github/workflows/tests.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212

1313
strategy:
1414
matrix:
15-
php: [8.1, 8.2, 8.3]
15+
php: [8.1, 8.2, 8.3, 8.4]
1616
laravel: [10.*, 11.*, 12.*]
1717
stability: [prefer-lowest, prefer-stable]
1818
os: [ubuntu-latest]
@@ -25,11 +25,17 @@ jobs:
2525
php: 8.3
2626
laravel: 11.*
2727
stability: prefer-stable
28+
- os: windows-latest
29+
php: 8.4
30+
laravel: 11.*
31+
stability: prefer-stable
2832
exclude:
2933
- php: 8.1
3034
laravel: 11.*
3135
- php: 8.1
3236
laravel: 12.*
37+
- php: 8.4
38+
laravel: 10.*
3339

3440
name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.stability }} - ${{ matrix.os }}
3541

composer.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22
"name": "statamic/migrator",
33
"type": "statamic-addon",
44
"require": {
5-
"friendsofphp/php-cs-fixer": "^3.54.0",
5+
"friendsofphp/php-cs-fixer": "^3.80.0",
66
"league/flysystem-aws-s3-v3": "~1.0 || ~3.0",
77
"mustangostang/spyc": "dev-master#dfd9aadc1f5224065d55b42b712c7e99a50a3f4d"
88
},
99
"require-dev": {
10-
"statamic/cms": "^5.0",
10+
"statamic/cms": "^5.41",
1111
"mockery/mockery": "^1.4.4",
12-
"orchestra/testbench": "^8.0 || ^9.0 || ^10.0",
13-
"phpunit/phpunit": "^10.0 || ^11.0"
12+
"orchestra/testbench": "^8.28 || ^9.6.1 || ^10.0",
13+
"phpunit/phpunit": "^10.5.35 || ^11.0"
1414
},
1515
"autoload": {
1616
"psr-4": {

0 commit comments

Comments
 (0)