Disable docker login for external contributor (#3588)

* Remove unused imports

* Remove docker login from kurtosis.yml

Three steps removed as they are not needed to run interop test.
And also allow external contributor to run the CI.
- docker login action (not needed)
- docker buildx action (not needed)
- caching docker layer (not working btw)

* Disable docker login for external contributor

* Fix comparison

Author: jangko

.github/workflows/kurtosis.yml

@@ -50,32 +50,29 @@ jobs:
       failed_test_status: ${{ steps.test_result.outputs.failed_test_status }}
     runs-on: ubuntu-latest
 
+    env:
+      # Disable login for external contributors.
+      ENABLE_LOGIN: ${{ secrets.DOCKERHUB_USERNAME != '' && secrets.DOCKERHUB_TOKEN != '' }}
+
     steps:
     - name: Checkout repository
       uses: actions/checkout@v4
 
+    # Without docker login we get rate limited when multiple PRs are coming in.
+    # Leading to a cascade of failure for the PRs after that.
+    # But since external contributor PRs are rare, the default rate limit
+    # 200 PRs/6 hours seems adequate.
     - name: Login to Docker Hub
+      if: ${{ env.ENABLE_LOGIN == 'true' }}
       uses: docker/login-action@v3
       with:
         username: ${{ secrets.DOCKERHUB_USERNAME }}
         password: ${{ secrets.DOCKERHUB_TOKEN }}
 
-    - name: Set up Docker Buildx
-      uses: docker/setup-buildx-action@v2
-
-    - name: Cache Docker layers
-      uses: actions/cache@v3
-      with:
-        path: /tmp/.buildx-cache
-        key: ${{ runner.os }}-buildx-${{ github.sha }}
-        restore-keys: |
-          ${{ runner.os }}-buildx-
-
     - name: Build Docker image
       shell: bash
       run: docker build . -t localtestnet
 
-
     - name: Set up Kurtosis
       shell: bash
       run: |

tests/eest/eest_blockchain.nim

@@ -8,8 +8,7 @@
 # those terms.
 
 import
-  std/[json, cmdline, os],
-  unittest2,
+  std/json,
   eth/common/headers_rlp,
   web3/eth_api_types,
   web3/engine_api_types,
@@ -25,10 +24,7 @@ import
   ../../hive_integration/nodocker/engine/engine_client,
   ./eest_helpers,
   stew/byteutils,
-  chronos,
-  ../../execution_chain/db/ledger,
-  ../../execution_chain/core/chain/forked_chain,
-  ../../execution_chain/common/common
+  chronos
 
 proc parseBlocks*(node: JsonNode): seq[BlockDesc] =
   for x in node:
@@ -94,10 +90,14 @@ proc processFile*(fileName: string): bool =
   return testPass
 
 when isMainModule:
+  import
+    os,
+    unittest2
+
   if paramCount() == 0:
     let testFile = getAppFilename().splitPath().tail
     echo "Usage: " & testFile & " vector.json"
     quit(QuitFailure)
-  
+
   check processFile(paramStr(1))
 

tests/eest/eest_blockchain_test.nim

@@ -8,7 +8,7 @@
 # those terms.
 
 import
-  std/[os, osproc],
+  std/os,
   unittest2,
   ./eest_helpers,
   ./eest_blockchain