Bump golangci-lint and fix new warnings (#57)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: stefanb

.github/workflows/golangci-lint.yml

@@ -21,7 +21,7 @@ jobs:
         with:
           go-version: "stable"
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@ec5d18412c0aeab7936cb16880d708ba2a64e1ae # v6.2.0
+        uses: golangci/golangci-lint-action@1481404843c368bc19ca9406f87d6e0fc97bdcfd # v7.0.0
         with:
           # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
           version: latest

osmshortlink.go

@@ -71,10 +71,10 @@ func Decode(s string) (float64, float64, int, error) {
 	var i int
 	var x int64 = 0
 	var y int64 = 0
-	var z int = -8
+	var z = -8
 	for i = 0; i < len(s); i++ {
-		var digit int = -1
-		var c byte = s[i]
+		var digit = -1
+		var c = s[i]
 		for j := 0; j < len(intToBase64); j++ {
 			if c == intToBase64[j] {
 				digit = j
@@ -98,8 +98,8 @@ func Decode(s string) (float64, float64, int, error) {
 		z += 3
 	}
 
-	var lon float64 = float64(x)*math.Pow(float64(2), float64(2-3*i))*90.0 - float64(180)
-	var lat float64 = float64(y)*math.Pow(float64(2), float64(2-3*i))*45.0 - float64(90)
+	var lon = float64(x)*math.Pow(float64(2), float64(2-3*i))*90.0 - float64(180)
+	var lat = float64(y)*math.Pow(float64(2), float64(2-3*i))*45.0 - float64(90)
 	// adjust z
 	if i < len(s) && s[i] == '-' {
 		z -= 2