Skip to content

Conversation

@eleumik
Copy link
Contributor

@eleumik eleumik commented Sep 10, 2025

fixed parse of 0. in strict mode

fixed parse of `0.` in strict mode
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@stleary
Copy link
Owner

stleary commented Sep 10, 2025

Please fix the blocking SonarQube issue

For future reference, it's better to combine small related fixes like #1008 and #1009, to simplify review testing.

string = sb.toString().trim();
if ("".equals(string)) {
throw this.syntaxError("Missing value");
} else if (jsonParserConfiguration != null &&
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests (see comment for #1008)

@stleary
Copy link
Owner

stleary commented Sep 13, 2025

What problem does this code solve?
Strict mode was not checking for number ending with '.'

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, but new unit tests are needed. Code review action item left

Was any code refactored in this commit?
No

Review status
APPROVED

Starting 3-day comment window

@stleary
Copy link
Owner

stleary commented Sep 13, 2025

@eleumik PR is approved, but please add unit test coverage and fix the SonarQube issues. Otherwise, I will add update the code after the merge.

Copy link
Owner

@stleary stleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open comments will be addresssed in a future commit

@stleary stleary merged commit a5e234a into stleary:master Sep 19, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants