-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Update JSONTokener.java for #1007 #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixed parse of `0.` in strict mode
|
|
Please fix the blocking SonarQube issue For future reference, it's better to combine small related fixes like #1008 and #1009, to simplify review testing. |
| string = sb.toString().trim(); | ||
| if ("".equals(string)) { | ||
| throw this.syntaxError("Missing value"); | ||
| } else if (jsonParserConfiguration != null && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests (see comment for #1008)
|
What problem does this code solve? Does the code still compile with Java6? Risks Changes to the API? Will this require a new release? Should the documentation be updated? Does it break the unit tests? Was any code refactored in this commit? Review status Starting 3-day comment window |
|
@eleumik PR is approved, but please add unit test coverage and fix the SonarQube issues. Otherwise, I will add update the code after the merge. |
stleary
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open comments will be addresssed in a future commit




fixed parse of
0.in strict mode