Skip to content

Commit d75d863

Browse files
authored
Fix useSimpleNavigation for catch-all routes. (#89)
* Fix useSimpleNavigation for catch-all routes. * bump version
1 parent 019c1cc commit d75d863

File tree

5 files changed

+13
-18
lines changed

5 files changed

+13
-18
lines changed

package-lock.json

Lines changed: 7 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-storefront",
3-
"version": "8.3.2",
3+
"version": "8.3.3",
44
"description": "Build and deploy e-commerce progressive web apps (PWAs) in record time.",
55
"module": "./index.js",
66
"license": "Apache-2.0",
@@ -44,7 +44,6 @@
4444
"formidable": "^1.2.1",
4545
"isomorphic-unfetch": "^3.0.0",
4646
"next-offline": "^5.0.0",
47-
"path-to-regexp": "^3.1.0",
4847
"qs": "^6.9.0",
4948
"react-image-magnify": "^2.7.4",
5049
"react-swipeable-views": "0.13.3",

src/router/useSimpleNavigation.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ function fetchRouteManifest() {
6363

6464
function getRoute(href, routes) {
6565
for (let pattern in routes) {
66-
if (new RegExp(pattern).test(href)) {
66+
if (new RegExp(pattern, 'i').test(href)) {
6767
return routes[pattern].as
6868
}
6969
}

src/server/getRoutes.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1-
const pathToRegexp = require('path-to-regexp')
1+
import { getRouteRegex } from 'next/dist/next-server/lib/router/utils/route-regex'
22

33
export default function routes(pagesManifest) {
44
const routes = {}
55

66
for (let as in pagesManifest) {
77
const component = pagesManifest[as]
8-
const route = pathToRegexp(as.replace(/\[([^\]]+)\]/g, ':$1')).source
8+
const route = getRouteRegex(as).re.source
9+
910
routes[route] = {
1011
component,
1112
as,

test/server/getRoutes.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ describe('getRoutes', () => {
1111

1212
expect(routes).toStrictEqual({
1313
'^\\/_app(?:\\/)?$': { component: 'static/development/pages/_app.js', as: '/_app' },
14-
'^\\/p\\/([^\\/]+?)(?:\\/)?$': {
14+
'^\\/p\\/([^/]+?)(?:\\/)?$': {
1515
component: 'static/development/pages/p/[productId].js',
1616
as: '/p/[productId]',
1717
},

0 commit comments

Comments
 (0)