editor: skip markdown clipboard parsing if markdown shortcuts is disabled #8604
Conversation
…bled Signed-off-by: 01zulfi <[email protected]>
| parseMarkdownOnPaste = true | ||
| ): Slice { | ||
| if (!plain && isProbablyMarkdown(text)) { | ||
| if (!plain && parseMarkdownOnPaste && isProbablyMarkdown(text)) { |
There was a problem hiding this comment.
unrelated comment: plain is true when content is pasted via ctrl+shift+v but false if pasted view right click > paste as plain text. I haven't found any answer for this yet
There was a problem hiding this comment.
plain is set by prosemirror I think. Might be worth investigating.
|
The changes look okay but I am not sure if we should mix the two. It's possible that a user has disabled markdown shortcuts but still wants to paste markdown. If we mix the two it'll annoy users. |
I would agree, but markdown shortcuts was recently upgraded to premium. |
That doesn't change what I said though. Paid users could still want to disable markdown but keep pasting markdown. |
Hi! I would like to suggest that it would be much better if you could provide an option in the settings for users to choose whether to turn this feature on or off. I believe Notesnook offers more features than its competitors, but it can be frustrating when a feature I don't need is enabled by default and cannot be disabled. For example, Notesnook shows a preview for notes, but there is no way to turn it off. |
3 participants
Closes #8597