structurizr-inspection: Fixes a bug preventing inspection severity to be specified via linked relationships.

Author: simonbrowndotje

changelog.md

@@ -29,6 +29,7 @@
 - structurizr-inspection: Adds a way to disable inspections via a workspace property named `structurizr.inspection` (`false` to disable).
 - structurizr-inspection: Default inspector adds a summary of error/warning/info/ignore counts as workspace properties.
 - structurizr-inspection: Fixes `model.deploymentnode.technology` (it was checking the description property rather than technology).
+- structurizr-inspection: Fixes a bug preventing inspection severity to be specified via linked relationships.
 
 ## v4.1.0 (28th May 2025)
 

structurizr-inspection/src/main/java/com/structurizr/inspection/PropertyBasedSeverityStrategy.java

@@ -69,7 +69,7 @@ public Severity getSeverity(Inspection inspection, Relationship relationship) {
         Element source = relationship.getSource();
         Relationship linkedRelationship = null;
         if (!StringUtils.isNullOrEmpty(relationship.getLinkedRelationshipId())) {
-            inspection.getWorkspace().getModel().getRelationship(relationship.getLinkedRelationshipId());
+            linkedRelationship = inspection.getWorkspace().getModel().getRelationship(relationship.getLinkedRelationshipId());
         }
 
         String allRelationshipsType = inspection.getType();

structurizr-inspection/src/test/java/com/structurizr/inspection/PropertyBasedSeverityStrategyTests.java

@@ -5,10 +5,7 @@
 import com.structurizr.inspection.model.RelationshipDescriptionInspection;
 import com.structurizr.inspection.model.RelationshipTechnologyInspection;
 import com.structurizr.inspection.workspace.WorkspaceScopeInspection;
-import com.structurizr.model.Component;
-import com.structurizr.model.Container;
-import com.structurizr.model.Relationship;
-import com.structurizr.model.SoftwareSystem;
+import com.structurizr.model.*;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
@@ -254,4 +251,21 @@ void getSeverityForRelationship_BetweenComponents_WhenSpecifiedByRelationshipTyp
         assertEquals(Severity.INFO, severityStrategy.getSeverity(inspection, relationship));
     }
 
+    @Test
+    void getSeverityForRelationship_WhenSpecifiedInLinkedRelationship() {
+        inspection = new RelationshipTechnologyInspection(inspector);
+        SoftwareSystem softwareSystem = workspace.getModel().addSoftwareSystem("Software System");
+        workspace.getModel().setImpliedRelationshipsStrategy(new CreateImpliedRelationshipsUnlessAnyRelationshipExistsStrategy());
+        Container container1 = softwareSystem.addContainer("Container 1");
+        Component component1 = container1.addComponent("Component 1");
+        Container container2 = softwareSystem.addContainer("Container 2");
+        Component component2 = container2.addComponent("Component 2");
+        Relationship relationship = component1.uses(component2, "");
+        Relationship impliedRelationship = container1.getEfferentRelationshipWith(container2);
+
+        // specify in original relationship
+        relationship.addProperty("structurizr.inspection.model.relationship.technology", "info");
+        assertEquals(Severity.INFO, severityStrategy.getSeverity(inspection, impliedRelationship));
+    }
+
 }