Skip to content

Commit 3b73765

Browse files
structurizr-inspection: Fixes model.deploymentnode.technology (it was checking the description property rather than technology).
1 parent 3710689 commit 3b73765

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
- structurizr-dsl: Adds support for a `jump` property on relationship styles.
1616
- structurizr-inspection: Adds a way to disable inspections via a workspace property named `structurizr.inspection` (`false` to disable).
1717
- structurizr-inspection: Default inspector adds a summary of error/warning/info/ignore counts as workspace properties.
18+
- structurizr-inspection: Fixes `model.deploymentnode.technology` (it was checking the description property rather than technology).
1819

1920
## v4.1.0 (28th May 2025)
2021

structurizr-inspection/src/main/java/com/structurizr/inspection/model/DeploymentNodeTechnologyInspection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public DeploymentNodeTechnologyInspection(Inspector inspector) {
1313

1414
@Override
1515
protected Violation inspect(DeploymentNode deploymentNode) {
16-
if (StringUtils.isNullOrEmpty(deploymentNode.getDescription())) {
16+
if (StringUtils.isNullOrEmpty(deploymentNode.getTechnology())) {
1717
return violation("The " + terminologyFor(deploymentNode).toLowerCase() + " \"" + nameOf(deploymentNode) + "\" is missing a technology.");
1818
}
1919

structurizr-inspection/src/test/java/com/structurizr/inspection/model/DeploymentNodeTechnologyInspectionTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
@Test
1818
public void run_WithoutDescription() {
1919
Workspace workspace = new Workspace("Name", "Description");
20-
DeploymentNode deploymentNode = workspace.getModel().addDeploymentNode("Name");
20+
DeploymentNode deploymentNode = workspace.getModel().addDeploymentNode("Name", "Description", "");
2121

2222
Violation violation = new DeploymentNodeTechnologyInspection(new DefaultInspector(workspace)).run(deploymentNode);
2323
Assertions.assertEquals(Severity.ERROR, violation.getSeverity());

0 commit comments

Comments
 (0)