Revert "fix(query): record state_rows in aggregate payload (databendlabs#17194)"

This reverts commit 64c53b2.

Author: sundy-li

src/query/expression/src/aggregate/partitioned_payload.rs

@@ -108,7 +108,6 @@ impl PartitionedPayload {
                 &state.empty_vector,
                 &state.group_hashes,
                 &mut state.addresses,
-                &mut state.page_index,
                 new_group_rows,
                 group_columns,
             );
@@ -135,7 +134,6 @@ impl PartitionedPayload {
                         sel,
                         &state.group_hashes,
                         &mut state.addresses,
-                        &mut state.page_index,
                         count,
                         group_columns,
                     );

src/query/expression/src/aggregate/payload.rs

@@ -78,7 +78,6 @@ unsafe impl Sync for Payload {}
 pub struct Page {
     pub(crate) data: Vec<MaybeUninit<u8>>,
     pub(crate) rows: usize,
-    pub(crate) state_rows: usize,
     pub(crate) capacity: usize,
 }
 
@@ -168,26 +167,21 @@ impl Payload {
     }
 
     #[inline]
-    pub fn writable_page(&mut self) -> (&mut Page, usize) {
+    pub fn writable_page(&mut self) -> &mut Page {
         if self.current_write_page == 0
             || self.pages[self.current_write_page - 1].rows
                 == self.pages[self.current_write_page - 1].capacity
         {
             self.current_write_page += 1;
             if self.current_write_page > self.pages.len() {
-                let data = Vec::with_capacity(self.row_per_page * self.tuple_size);
                 self.pages.push(Page {
-                    data,
+                    data: Vec::with_capacity(self.row_per_page * self.tuple_size),
                     rows: 0,
-                    state_rows: 0,
                     capacity: self.row_per_page,
                 });
             }
         }
-        (
-            &mut self.pages[self.current_write_page - 1],
-            self.current_write_page - 1,
-        )
+        &mut self.pages[self.current_write_page - 1]
     }
 
     #[inline]
@@ -200,27 +194,31 @@ impl Payload {
         select_vector: &SelectVector,
         group_hashes: &[u64],
         address: &mut [*const u8],
-        page_index: &mut [usize],
         new_group_rows: usize,
         group_columns: InputColumns,
     ) {
         let tuple_size = self.tuple_size;
-        let (mut page, mut page_index_value) = self.writable_page();
+        let mut page = self.writable_page();
         for idx in select_vector.iter().take(new_group_rows).copied() {
             address[idx] = unsafe { page.data.as_ptr().add(page.rows * tuple_size) as *const u8 };
-            page_index[idx] = page_index_value;
             page.rows += 1;
 
             if page.rows == page.capacity {
-                (page, page_index_value) = self.writable_page();
+                page = self.writable_page();
             }
         }
 
+        self.total_rows += new_group_rows;
+
+        debug_assert_eq!(
+            self.total_rows,
+            self.pages.iter().map(|x| x.rows).sum::<usize>()
+        );
+
         self.append_rows(
             select_vector,
             group_hashes,
             address,
-            page_index,
             new_group_rows,
             group_columns,
         )
@@ -231,7 +229,6 @@ impl Payload {
         select_vector: &SelectVector,
         group_hashes: &[u64],
         address: &mut [*const u8],
-        page_index: &mut [usize],
         new_group_rows: usize,
         group_columns: InputColumns,
     ) {
@@ -303,16 +300,8 @@ impl Payload {
                 for (aggr, offset) in self.aggrs.iter().zip(self.state_addr_offsets.iter()) {
                     aggr.init_state(place.next(*offset));
                 }
-                self.pages[page_index[idx]].state_rows += 1;
             }
         }
-
-        self.total_rows += new_group_rows;
-
-        debug_assert_eq!(
-            self.total_rows,
-            self.pages.iter().map(|x| x.rows).sum::<usize>()
-        );
     }
 
     pub fn combine(&mut self, mut other: Payload) {
@@ -338,7 +327,7 @@ impl Payload {
         address: &[*const u8],
     ) {
         let tuple_size = self.tuple_size;
-        let (mut page, _) = self.writable_page();
+        let mut page = self.writable_page();
         for i in 0..row_count {
             let index = select_vector[i];
 
@@ -352,7 +341,7 @@ impl Payload {
             page.rows += 1;
 
             if page.rows == page.capacity {
-                (page, _) = self.writable_page();
+                page = self.writable_page();
             }
         }
 
@@ -423,12 +412,18 @@ impl Drop for Payload {
             if !self.state_move_out {
                 for (aggr, addr_offset) in self.aggrs.iter().zip(self.state_addr_offsets.iter()) {
                     if aggr.need_manual_drop_state() {
-                        for page in self.pages.iter() {
-                            for row in 0..page.state_rows {
+                        'PAGE_END: for page in self.pages.iter() {
+                            for row in 0..page.rows {
                                 let ptr = self.data_ptr(page, row);
                                 unsafe {
                                     let state_addr =
                                         read::<u64>(ptr.add(self.state_offset) as _) as usize;
+
+                                    // row is reserved, but not written (maybe throw by oom error)
+                                    if state_addr == 0 {
+                                        break 'PAGE_END;
+                                    }
+
                                     let state_place = StateAddr::new(state_addr);
                                     aggr.drop_state(state_place.next(*addr_offset));
                                 }

src/query/expression/src/aggregate/probe_state.rs

@@ -22,7 +22,6 @@ use crate::BATCH_SIZE;
 pub struct ProbeState {
     pub group_hashes: [u64; BATCH_SIZE],
     pub addresses: [*const u8; BATCH_SIZE],
-    pub page_index: [usize; BATCH_SIZE],
     pub state_places: [StateAddr; BATCH_SIZE],
     pub group_compare_vector: SelectVector,
     pub no_match_vector: SelectVector,
@@ -39,7 +38,6 @@ impl Default for ProbeState {
         Self {
             group_hashes: [0_u64; BATCH_SIZE],
             addresses: [std::ptr::null::<u8>(); BATCH_SIZE],
-            page_index: [0; BATCH_SIZE],
             state_places: [StateAddr::new(0); BATCH_SIZE],
             group_compare_vector: new_sel(),
             no_match_vector: new_sel(),