Applys enhanced ruff linting rules

Author: CyclingNinja

.cruft.json

@@ -16,7 +16,7 @@
       "enable_dynamic_dev_versions": "y",
       "include_example_code": "n",
       "include_cruft_update_github_workflow": "y",
-      "use_extended_ruff_linting": "n",
+      "use_extended_ruff_linting": "y",
       "_sphinx_theme": "sunpy",
       "_parent_project": "",
       "_install_requires": "",

.github/workflows/ci.yml

@@ -12,7 +12,7 @@ on:
       - '!*pre*'
       - '!*post*'
   pull_request:
-# Allow manual runs through the web UI
+  # Allow manual runs through the web UI
   workflow_dispatch:
 
 concurrency:
@@ -90,27 +90,6 @@ jobs:
       submodules: false
       coverage: codecov
       toxdeps: tox-pypi-filter
-    secrets:
-      CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
-
-  publish:
-    # Build wheels on PRs only when labelled. Releases will only be published if tagged ^v.*
-    # see https://github-actions-workflows.openastronomy.org/en/latest/publish.html#upload-to-pypi
-    if: |
-      github.event_name != 'pull_request' ||
-      (
-        github.event_name == 'pull_request' &&
-        contains(github.event.pull_request.labels.*.name, 'Run publish')
-      )
-    needs: [test, docs]
-    uses: OpenAstronomy/github-actions-workflows/.github/workflows/publish_pure_python.yml@main
-    with:
-      python-version: '3.12'
-      test_extras: 'tests'
-      test_command: 'pytest -p no:warnings --doctest-rst --pyargs sunpy_soar'
-      submodules: false
-    secrets:
-      pypi_token: ${{ secrets.pypi_token }}
       envs: |
         - linux: py312-devdeps
     secrets:

.ruff.toml

@@ -1,5 +1,3 @@
-# Allow unused variables when underscore-prefixed.
-lint.dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$"
 target-version = "py310"
 line-length = 120
 exclude=[
@@ -14,9 +12,27 @@ select = [
   "E",
   "F",
   "W",
+  "N",
   "UP",
   "PT",
+  "BLE",
+  "A",
+  "C4",
+  "INP",
+  "PIE",
+  "T20",
+  "RET",
+  "TID",
+  "PTH",
+  "PD",
+  "PLC",
+  "PLE",
+  "FLY",
+  "NPY",
+  "PERF",
+  "RUF",
 ]
+
 extend-ignore = [
   # pycodestyle (E, W)
   "E501", # ignore line length will use a formatter instead
@@ -51,10 +67,8 @@ extend-ignore = [
   "INP001", # File is part of an implicit namespace package.
 ]
 "docs/conf.py" = [
-  "E402" # Module imports not at top of file
-]
-"docs/conf.py" = [
-    "INP001", # conf.py is part of an implicit namespace package
+  "E402", # Module imports not at top of file
+  "INP001", # conf.py is part of an implicit namespace package
 ]
 "docs/*.py" = [
   "INP001", # File is part of an implicit namespace package.

pyproject.toml

@@ -29,18 +29,15 @@ tests = [
   "pytest",
   "sunpy[map,net]>=5.0",
 ]
+
 docs = [
-  "matplotlib",
+  "sphinx",
   "sphinx-automodapi",
-  "sunpy-sphinx-theme",
   "packaging",
-]
-repository = [
-  "https://sunpy.org",
+  "matplotlib",
   "sphinx-changelog",
   "sphinx-copybutton",
   "sphinx-gallery",
-  "sphinx",
   "sphinxext-opengraph",
   "sunpy-sphinx-theme",
 ]