[Chat] Add streaming support & persistence to storage through accumulator callback chaining #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-jouwweb
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
changed the title
chr-hertel
reviewed
Nov 21, 2025
OskarStark
changed the title
carsonbot
changed the title
OskarStark
changed the title
OskarStark
reviewed
Nov 24, 2025
OskarStark
reviewed
Nov 24, 2025
OskarStark
reviewed
Nov 24, 2025
marco-jouwweb
force-pushed
the
feature/stream-support-chat-storage
branch
2 times, most recently
from
a914377 to
10d190c
Compare
added 11 commits
November 24, 2025 11:38
…accumulator callback chaining
marco-jouwweb
force-pushed
the
feature/stream-support-chat-storage
branch
from
a1f4c83 to
8a71916
Compare
Guikingone
reviewed
Nov 28, 2025
| $this->onComplete = $onComplete; | ||
| } | ||
|
|
||
| public function addOnComplete(\Closure $callback): void |
Contributor
There was a problem hiding this comment.
Would renamed it to onComplete()
|
|
||
| public function __construct( | ||
| private readonly StreamResult|ToolboxStreamResult $innerResult, | ||
| ?\Closure $onComplete = null, |
Contributor
There was a problem hiding this comment.
Couldn't be declared as a property?
| - Add `StreamableStoreInterface` which indicates `StoreInterface` implementation can be configured with streaming | ||
| - Add `AccumulatingStreamResult` wrapper class which adds accumulation logic & callback chaining to `StreamResult` implementations (can wrap both `Agent` and `Platform` variants) to return the full message once `Generator` is exhausted | ||
| - Streamed responses now also create `AssistantMessage` & are added to `Store` in `Chat::submit()` | ||
| - Bugfixed loss of metadata in `Chat::submit()` |
Contributor
There was a problem hiding this comment.
Should be added after the list of stores IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Chat::submit()function didn't support streaming. I have added support for this through:AccumulatingStreamResultwrapper which allows callback chaining and accumulates the full message (callbacks are fired onceGeneratorin innerStreamResultis exhausted, aka when stream has completed)StreamResultclasses with this wrapper inside theChat::submit()functionStoragewith a newAssistantMessagebuilt from the accumulated message (as non-stream responses are also automatically added to storage inChat::submit())Other changes:
StreamableStoreInterfacewhich indicates aStoreimplementation supports streaming. Currently added to all stores exceptSessionStorage(due to inherent issues with headers being already sent; deferred updates through callbacks go against nature of header/session lifecycles in Symfony; discussed with @Guikingone)Chat::submit()(metadata was not transferred to newAssistantMessagewe created)Chat::submit()combination