Merge pull request #28197 from taosdata/fix/fixDoubleSendMain

hzcheng · web-flow · commit 0f4456bd8b7e · 2024-09-29T21:30:23.000+08:00
fix double free
diff --git a/source/libs/transport/src/thttp.c b/source/libs/transport/src/thttp.c
@@ -677,7 +677,7 @@ static void httpHandleReq(SHttpMsg* msg) {
     tError("http-report failed to connect to http-server,dst:%s:%d, chanId:%" PRId64 ", seq:%" PRId64 ", reson:%s",
            cli->addr, cli->port, chanId, cli->seq, uv_strerror(ret));
     httpFailFastMayUpdate(http->connStatusTable, cli->addr, cli->port, 0);
-    destroyHttpClient(cli);
+    uv_close((uv_handle_t*)&cli->tcp, httpDestroyClientCb);
   }
   TAOS_UNUSED(taosReleaseRef(httpRefMgt, chanId));
   return;

Original file line number	Diff line number	Diff line change
`@@ -677,7 +677,7 @@ static void httpHandleReq(SHttpMsg* msg) {`
`677`	`677`	`tError("http-report failed to connect to http-server,dst:%s:%d, chanId:%" PRId64 ", seq:%" PRId64 ", reson:%s",`
`678`	`678`	`cli->addr, cli->port, chanId, cli->seq, uv_strerror(ret));`
`679`	`679`	`httpFailFastMayUpdate(http->connStatusTable, cli->addr, cli->port, 0);`
`680`		`- destroyHttpClient(cli);`
	`680`	`+ uv_close((uv_handle_t*)&cli->tcp, httpDestroyClientCb);`
`681`	`681`	`}`
`682`	`682`	`TAOS_UNUSED(taosReleaseRef(httpRefMgt, chanId));`
`683`	`683`	`return;`