Leak copy which allow us to always use by_value

Author: tautropfli

src/fraction.rs

@@ -78,7 +78,7 @@ where
 {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         let (sign, numerator, denominator) =
-            extract_sign(self.numerator.to_impl(), self.denominator.to_impl(), f);
+            extract_sign(self.numerator.into_impl(), self.denominator.into_impl(), f);
 
         if let Some(sign) = sign {
             f.write_char(sign)?;

src/integer.rs

@@ -158,8 +158,8 @@ macro_rules! impl_signed_integer {
             impl crate::ToIntegerImpl for $ty {
                 type Impl = $ty;
 
-                fn to_impl(&self) -> $ty {
-                    *self
+                fn into_impl(self) -> $ty {
+                    self
                 }
             }
 

src/lib.rs

@@ -70,7 +70,7 @@
 /// }
 /// ```
 #[allow(private_bounds)]
-pub trait Integer: ToIntegerImpl {}
+pub trait Integer: ToIntegerImpl + Copy {}
 
 /// Abstraction over signed integer types.
 pub trait SignedInteger: Integer {}
@@ -82,7 +82,7 @@ pub trait UnsignedInteger: Integer {}
 pub(crate) trait ToIntegerImpl {
     type Impl: crate::integer::IntegerImpl<Public = Self>;
 
-    fn to_impl(&self) -> Self::Impl;
+    fn into_impl(self) -> Self::Impl;
 }
 
 mod sub_superscript;

src/seven_segment.rs

@@ -50,7 +50,7 @@ where
     T: UnsignedInteger,
 {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        fmt_seven_segment::<_, <T::Impl as IntegerImpl>::BaseTwo>(self.0.to_impl(), f)
+        fmt_seven_segment::<_, <T::Impl as IntegerImpl>::BaseTwo>(self.0.into_impl(), f)
     }
 }
 
@@ -59,7 +59,7 @@ where
     T: UnsignedInteger,
 {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        fmt_seven_segment::<_, <T::Impl as IntegerImpl>::BaseTen>(self.0.to_impl(), f)
+        fmt_seven_segment::<_, <T::Impl as IntegerImpl>::BaseTen>(self.0.into_impl(), f)
     }
 }
 

src/sub_superscript.rs

@@ -43,7 +43,7 @@ where
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         fmt_number_with_base_and_digits::<_, <T::Impl as IntegerImpl>::BaseTen>(
             f,
-            self.0.to_impl(),
+            self.0.into_impl(),
             '⁺',
             '⁻',
             &['⁰', '¹', '²', '³', '⁴', '⁵', '⁶', '⁷', '⁸', '⁹'],
@@ -58,7 +58,7 @@ where
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         fmt_number_with_base_and_digits::<_, <T::Impl as IntegerImpl>::BaseTwo>(
             f,
-            self.0.to_impl(),
+            self.0.into_impl(),
             '⁺',
             '⁻',
             &['⁰', '¹'],
@@ -106,7 +106,7 @@ where
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         fmt_number_with_base_and_digits::<_, <T::Impl as IntegerImpl>::BaseTen>(
             f,
-            self.0.to_impl(),
+            self.0.into_impl(),
             '₊',
             '₋',
             &['₀', '₁', '₂', '₃', '₄', '₅', '₆', '₇', '₈', '₉'],
@@ -121,7 +121,7 @@ where
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         fmt_number_with_base_and_digits::<_, <T::Impl as IntegerImpl>::BaseTwo>(
             f,
-            self.0.to_impl(),
+            self.0.into_impl(),
             '₊',
             '₋',
             &['₀', '₁'],

src/tally_marks.rs

@@ -38,7 +38,7 @@ where
     T: UnsignedInteger,
 {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        fmt_tally_marks(self.0.to_impl(), f)
+        fmt_tally_marks(self.0.into_impl(), f)
     }
 }