golangci-lint update

Author: tbmatuka

.golangci.yml

@@ -2,12 +2,14 @@
 linters-settings:
   govet:
     check-shadowing: true
-  revive:
-    severity: warning
+  golint:
+    min-confidence: 0
   gocyclo:
     min-complexity: 42
   cyclop:
     max-complexity: 42
+  maligned:
+    suggest-new: true
   dupl:
     threshold: 200
   goconst:
@@ -19,23 +21,52 @@ linters-settings:
 linters:
   enable-all: true
   disable:
-    - exhaustivestruct
-    - funlen
-    - goconst
-    - godot
-    - goerr113
-    - golint
+    - golint # deprecated, replaced with revive
+    - interfacer # deprecated
+    - maligned # deprecated
+    - wrapcheck
+    - nlreturn
     - gomnd
-    - interfacer
+    - goerr113
+    - exhaustivestruct
+    - wsl
+    - whitespace
     - lll
-    - maligned
+    - scopelint
     - nestif
-    - nlreturn
+    - funlen
     - paralleltest
-    - scopelint
-    - whitespace
-    - wrapcheck
-    - wsl
+    - godot
+    - varnamelen
+    - ireturn
+    - ifshort
+    - thelper
+    - wastedassign
+    - goconst
+    - gci
+    - exhaustruct
+    - nonamedreturns
+    - interfacebloat
+    - dupword
+    - forcetypeassert #tmp needs to be on
+    - ifshort # deprecated
+    - structcheck # deprecated
+    - deadcode # deprecated
+    - nosnakecase # deprecated
+    - varcheck # deprecated
+    - rowserrcheck # deprecated
+    - sqlclosecheck # deprecated
+    - wastedassign # deprecated
+    - golint # deprecated
+    - interfacer # deprecated
+    - maligned # deprecated
+
+issues:
+  exclude:
+    # bugs of typecheck linter
+    - "undeclared name: `shellquote`"
+    - "github.com/kballard/go-shellquote\" imported but not used"
+    - "github.com/haproxytech/config-parser/v4/types\" imported but not used"
 
 run:
   skip-dirs:

cmd/internal/gowebhookexec/network.go

@@ -22,7 +22,7 @@ func Listen(config ViperConfig) {
 
 	if config.SslKey != "" && config.SslCert != "" {
 		log.Fatal(server.ListenAndServeTLS(config.SslCert, config.SslKey))
-	} else {
+	} else { //nolint:revive
 		log.Fatal(server.ListenAndServe())
 	}
 }