generator: add tests and improve error handling #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds comprehensive test coverage for the HCL transform system introduced in #991: - Unit tests for stringsToCtyList helper - Tests for makeListTransformFunction with uppercase and replace - Error case testing for invalid inputs - Transform composition tests Improves error handling and code quality: - Enhanced error messages showing variable names when multiple variables referenced - Clean eval context handling using fresh variable maps instead of deletion - Pre-allocated slices for better performance - Proper empty list handling in cty conversions - Comprehensive documentation of transform system All tests pass and generator continues to work correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #991 adding test coverage and improvements to the HCL transform system.
references 2 variables ([Foo, Bar]), expected exactly 1