ssd: Back to using server-side decoration

Anbox uses client-side decoration really badly. Some games don't have a
title bar and click misplaced. And because of the lack of some things like
_GTK_FRAME_EXTENTS in GTK+, the zoom area must be within the real window
range. This makes buttons that occupy the border of the window difficult
to click (Although a patch has made border smaller).
So, I forked Anbox and made it use server-side decoration again.
NOTE: You must use this fork with a customed Android image. (You can get source here: https://github.com/thdaemon/platform_manifests)

Author: thdaemon

src/anbox/platform/sdl/window.cpp

@@ -59,7 +59,7 @@ Window::Window(const std::shared_ptr<Renderer> &renderer,
   // initializing GL here will cause a surface to be created and the
   // renderer will attempt to create one too which will not work as
   // only a single surface per EGLNativeWindowType is supported.
-  std::uint32_t flags = SDL_WINDOW_BORDERLESS;
+  std::uint32_t flags = 0;
   if (resizable)
     flags |= SDL_WINDOW_RESIZABLE;
 
@@ -72,10 +72,6 @@ Window::Window(const std::shared_ptr<Renderer> &renderer,
     BOOST_THROW_EXCEPTION(std::runtime_error(message));
   }
 
-  if (utils::get_env_value("ANBOX_NO_SDL_WINDOW_HIT_TEST", "false") == "false")
-    if (SDL_SetWindowHitTest(window_, &Window::on_window_hit, this) < 0)
-      BOOST_THROW_EXCEPTION(std::runtime_error("Failed to register for window hit test"));
-
   SDL_SysWMinfo info;
   SDL_VERSION(&info.version);
   SDL_GetWindowWMInfo(window_, &info);
@@ -112,61 +108,6 @@ Window::~Window() {
   if (window_) SDL_DestroyWindow(window_);
 }
 
-SDL_HitTestResult Window::on_window_hit(SDL_Window *window, const SDL_Point *pt, void *data) {
-  auto platform_window = reinterpret_cast<Window*>(data);
-
-  int w = 0, h = 0;
-  SDL_GetWindowSize(window, &w, &h);
-
-  const auto border_size = graphics::dp_to_pixel(window_resize_border);
-  const auto top_drag_area_height = graphics::dp_to_pixel(top_drag_area);
-  const auto button_area_width = graphics::dp_to_pixel(button_size + button_padding * 2 + button_margin * 2);
-  const auto flags = SDL_GetWindowFlags(window);
-
-  if (flags & SDL_WINDOW_FULLSCREEN)
-      return SDL_HITTEST_NORMAL;
-
-  if (!(flags & SDL_WINDOW_RESIZABLE)) {
-    if (pt->y < border_size)
-      return SDL_HITTEST_DRAGGABLE;
-    else
-      return SDL_HITTEST_NORMAL;
-  }
-
-  if (pt->y < top_drag_area_height) {
-    if (pt->x > w - button_area_width && pt->x < w) {
-      platform_window->close();
-      return SDL_HITTEST_NORMAL;
-    } else if (pt->x > w - button_area_width * 2 && pt->x < w - button_area_width) {
-      platform_window->switch_window_state();
-      return SDL_HITTEST_NORMAL;
-    }
-    return SDL_HITTEST_DRAGGABLE;
-  }
-
-  if (flags & SDL_WINDOW_MAXIMIZED)
-    return SDL_HITTEST_NORMAL;
-
-  if (pt->x < border_size && pt->y < border_size)
-      return SDL_HITTEST_RESIZE_TOPLEFT;
-  else if (pt->x > border_size && pt->x < w - border_size && pt->y < border_size)
-      return SDL_HITTEST_RESIZE_TOP;
-  else if (pt->x > w - border_size && pt->y < border_size)
-      return SDL_HITTEST_RESIZE_TOPRIGHT;
-  else if (pt->x > w - border_size && pt->y > border_size && pt->y < h - border_size)
-      return SDL_HITTEST_RESIZE_RIGHT;
-  else if (pt->x > w - border_size && pt->y > h - border_size)
-      return SDL_HITTEST_RESIZE_BOTTOMRIGHT;
-  else if (pt->x < w - border_size && pt->x > border_size && pt->y > h - border_size)
-      return SDL_HITTEST_RESIZE_BOTTOM;
-  else if (pt->x < border_size && pt->y > h - border_size)
-      return SDL_HITTEST_RESIZE_BOTTOMLEFT;
-  else if (pt->x < border_size && pt->y < h - border_size && pt->y > border_size)
-      return SDL_HITTEST_RESIZE_LEFT;
-
-  return SDL_HITTEST_NORMAL;
-}
-
 void Window::close() {
   if (observer_)
     observer_->window_deleted(id_);
@@ -202,9 +143,6 @@ void Window::process_event(const SDL_Event &event) {
     case SDL_WINDOWEVENT_HIDDEN:
       break;
     case SDL_WINDOWEVENT_CLOSE:
-      if (observer_)
-        observer_->window_deleted(id_);
-
       close();
       break;
     default: