Merge pull request #167 from thephpleague/remove-unnecessary-trim

Remove unnecessary trim from ListItemRenderer

Author: colinodell

CHANGELOG.md

@@ -20,6 +20,7 @@ Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) princip
  - Changed tab/indentation handling to meet the new spec behavior
  - Modified spec tests to show spaces and tabs in test results
  - Replaced `HtmlRendererInterface` with `ElementRendererInterface` (#141)
+ - Removed the unnecessary `trim()` and string cast from `ListItemRenderer`
 
 ### Fixed
  - Fixed link reference definition edge case (#120)

src/Block/Renderer/ListItemRenderer.php

@@ -49,6 +49,6 @@ public function render(AbstractBlock $block, ElementRendererInterface $htmlRende
 
         $li = new HtmlElement('li', $attrs, $contents);
 
-        return trim($li);
+        return $li;
     }
 }

tests/unit/Block/Renderer/ListItemRendererTest.php

@@ -17,6 +17,7 @@
 use League\CommonMark\Block\Element\ListData;
 use League\CommonMark\Block\Element\ListItem;
 use League\CommonMark\Block\Renderer\ListItemRenderer;
+use League\CommonMark\HtmlElement;
 use League\CommonMark\Tests\Unit\FakeHtmlRenderer;
 
 class ListItemRendererTest extends \PHPUnit_Framework_TestCase
@@ -39,8 +40,9 @@ public function testRenderUnorderedList()
 
         $result = $this->renderer->render($block, $fakeRenderer);
 
-        $this->assertInternalType('string', $result);
-        $this->assertContains('<li id="::escape::id">::blocks::</li>', $result);
+        $this->assertTrue($result instanceof HtmlElement);
+        $this->assertEquals('li', $result->getTagName());
+        $this->assertEquals('<li id="::escape::id">::blocks::</li>', $result->__toString());
     }
 
     /**