Upgraded PHP version, migrated from phpspec to phpunit

Author: frankdejonge

.gitattributes

@@ -1,6 +1,7 @@
 * text=auto
 
 /spec export-ignore
+/src/*Test.php export-ignore
 /stub export-ignore
 /.gitattributes export-ignore
 /.gitignore export-ignore

.github/workflows/quality-assurance.yml

@@ -20,22 +20,19 @@ on:
 
 jobs:
   phpunit:
-    name: PHPUnit tests on ${{ matrix.php }} ${{ matrix.composer-flags }}
+    name: PHPUnit tests on ${{ matrix.php }}
     runs-on: ubuntu-latest
     continue-on-error: ${{ matrix.experimental }}
     strategy:
       fail-fast: false
       matrix:
-        php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2' ]
-        composer-flags: [ '' ]
+        php: [ '8.0', '8.1', '8.2', '8.3', '8.4' ]
         experimental: [false]
-        phpunit-flags: [ '--coverage-text' ]
     steps:
       - uses: actions/checkout@v3
       - uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
-          coverage: pcov
           tools: composer:v2
-      - run: composer update --no-progress ${{ matrix.composer-flags }}
+      - run: composer update --no-progress
       - run: composer test

composer.json

@@ -28,13 +28,12 @@
         }
     },
     "require": {
-        "php": ">=7.1"
+        "php": "^8.0"
     },
     "scripts": {
-        "test": "phpspec run"
+        "test": "phpunit src"
     },
     "require-dev": {
-        "phpspec/phpspec": ">=4.3",
-        "friends-of-phpspec/phpspec-code-coverage": ">=4.3"
+        "phpunit/phpunit": "^11.5"
     }
 }

spec/FingersCrossedProcessorSpec.php

@@ -0,0 +1,24 @@
+<?php
+declare(strict_types=1);
+
+namespace League\Pipeline;
+
+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\TestCase;
+
+class FingersCrossedProcessorTest extends TestCase
+{
+    #[Test]
+    public function it_can_process_stages(): void
+    {
+        $pipeline = new FingersCrossedProcessor();
+
+        $result = $pipeline->process(
+            2,
+            function ($payload) { return $payload * 2; },
+            function ($payload) { return $payload + 1; }
+        );
+
+        self::assertEquals(5, $result);
+    }
+}

spec/InterruptibleProcessorSpec.php

@@ -0,0 +1,26 @@
+<?php
+declare(strict_types=1);
+
+namespace League\Pipeline;
+
+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\TestCase;
+
+class InterruptibleProcessorTest extends TestCase
+{
+    #[Test]
+    public function it_can_process_stages(): void
+    {
+        $pipeline = new InterruptibleProcessor(function ($payload) {
+            return $payload < 3;
+        });
+
+        $result = $pipeline->process(
+            2,
+            function ($payload) { return $payload * 2; },
+            function ($payload) { return $payload + 1; }
+        );
+
+        self::assertEquals(4, $result);
+    }
+}

spec/PipelineBuilderSpec.php

@@ -8,23 +8,19 @@ class Pipeline implements PipelineInterface
     /**
      * @var callable[]
      */
-    private $stages = [];
+    private array $stages;
+    private ProcessorInterface $processor;
 
-    /**
-     * @var ProcessorInterface
-     */
-    private $processor;
-
-    public function __construct(ProcessorInterface $processor = null, callable ...$stages)
+    public function __construct(?ProcessorInterface $processor = null, callable ...$stages)
     {
         $this->processor = $processor ?? new FingersCrossedProcessor;
         $this->stages = $stages;
     }
 
-    public function pipe(callable $stage): PipelineInterface
+    public function pipe(callable $operation): PipelineInterface
     {
         $pipeline = clone $this;
-        $pipeline->stages[] = $stage;
+        $pipeline->stages[] = $operation;
 
         return $pipeline;
     }