in ?scale_color_continous, add link to ?continuous_scale #6691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding `continuous_scale` to @Seealso of ?scale_color_continous allows to more easily discover potential parameters to supply in `...` like `transform` or `limits`.
teunbrand
reviewed
Oct 9, 2025
Collaborator
teunbrand
left a comment
teunbrand
left a comment
There was a problem hiding this comment.
Thank you for the PR!
Here are some additional things we could consider, but it'll be fine without them.
added 2 commits
October 9, 2025 17:12
add scale_(color|fill)_discrete to @family color scales remove explit @Seealso links from ?scale_(color|fill)_(continous|binned) that are redundant due to links provided through @family add @Seealso links for discrete_scale continous_scale and binned_scales to scale_(fill|color)_(discrete|binned|continous) as appropiate
specifically, links to ?(discrete|continous|binned)_scale function in the description of the `...` parameter
Contributor
Author
|
In fb3d3a2 , I went one step further and added the links to the Should I squash the commits? |
teunbrand
approved these changes
Oct 10, 2025
Collaborator
There was a problem hiding this comment.
I went one step further
I liked this direction and I've replaced the ... documentation with an @inheritsParam, which spells out all the arguments too for extra completeness. Thank you for the contribution!
Should I squash the commits?
We usually squash-merge, so there is no need to do this on the PR's end of things
teunbrand
added a commit
to teunbrand/ggplot2
that referenced
this pull request
Oct 20, 2025
teunbrand
added a commit
that referenced
this pull request
Oct 20, 2025
* new colour scales feed first argument to `name` * add test * add news bullet * fix mismerged lines * account for interaction with #6691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
continuous_scaleto @Seealso of ?scale_color_continous allows to more easily discover potential parameters to supply in...liketransformorlimits.