Merge remote-tracking branch 'akuzm/compressed-bitmap' into HEAD

Author: akuzm

tsl/src/nodes/decompress_chunk/decompress_chunk.c

@@ -1982,18 +1982,6 @@ create_compressed_scan_paths(PlannerInfo *root, RelOptInfo *compressed_rel,
 		}
 	}
 
-	/*
-	 * We set enable_bitmapscan to false here to ensure any paths with bitmapscan do not
-	 * displace other paths. Note that setting the postgres GUC will not actually disable
-	 * the bitmapscan path creation but will instead create them with very high cost.
-	 * If bitmapscan were the dominant path after postgres planning we could end up
-	 * in a situation where we have no valid plan for this relation because we remove
-	 * bitmapscan paths from the pathlist.
-	 */
-
-	bool old_bitmapscan = enable_bitmapscan;
-	//	enable_bitmapscan = false;
-
 	if (sort_info->use_compressed_sort)
 	{
 		/*
@@ -2037,8 +2025,6 @@ create_compressed_scan_paths(PlannerInfo *root, RelOptInfo *compressed_rel,
 		check_index_predicates(root, compressed_rel);
 		create_index_paths(root, compressed_rel);
 	}
-
-	enable_bitmapscan = old_bitmapscan;
 }
 
 /*

tsl/test/expected/hypercore.out

@@ -245,15 +245,17 @@ SET enable_indexscan = false;
 SET timescaledb.enable_transparent_decompression TO 'hypercore';
 EXPLAIN (costs off, timing off, summary off)
 SELECT time, location, device, temp, humidity, jdata FROM :chunk WHERE device < 4 ORDER BY time, device LIMIT 5;
-                             QUERY PLAN                             
---------------------------------------------------------------------
+                                                  QUERY PLAN                                                  
+--------------------------------------------------------------------------------------------------------------
  Limit
    ->  Sort
          Sort Key: _hyper_1_1_chunk."time", _hyper_1_1_chunk.device
          ->  Custom Scan (DecompressChunk) on _hyper_1_1_chunk
-               ->  Seq Scan on compress_hyper_2_32_chunk
-                     Filter: (device < 4)
-(6 rows)
+               ->  Bitmap Heap Scan on compress_hyper_2_32_chunk
+                     Recheck Cond: (device < 4)
+                     ->  Bitmap Index Scan on compress_hyper_2_32_chunk_device__ts_meta_min_1__ts_meta_ma_idx
+                           Index Cond: (device < 4)
+(8 rows)
 
 SELECT time, location, device, temp, humidity, jdata FROM :chunk WHERE device < 4 ORDER BY time, device LIMIT 5;
              time             | location | device | temp |     humidity     |      jdata       

tsl/test/expected/hypercore_scans.out

@@ -1048,18 +1048,22 @@ set timescaledb.enable_transparent_decompression='hypercore';
 explain (costs off)
 select * from readings
 where time <= '2022-06-02' and device in (1, 4);
-                                                                  QUERY PLAN                                                                  
-----------------------------------------------------------------------------------------------------------------------------------------------
+                                                                       QUERY PLAN                                                                       
+--------------------------------------------------------------------------------------------------------------------------------------------------------
  Append
    ->  Custom Scan (DecompressChunk) on _hyper_1_1_chunk
          Vectorized Filter: ("time" <= 'Thu Jun 02 00:00:00 2022 PDT'::timestamp with time zone)
-         ->  Seq Scan on compress_hyper_2_7_chunk
-               Filter: ((_ts_meta_min_1 <= 'Thu Jun 02 00:00:00 2022 PDT'::timestamp with time zone) AND (device = ANY ('{1,4}'::integer[])))
+         ->  Bitmap Heap Scan on compress_hyper_2_7_chunk
+               Recheck Cond: ((device = ANY ('{1,4}'::integer[])) AND (_ts_meta_min_1 <= 'Thu Jun 02 00:00:00 2022 PDT'::timestamp with time zone))
+               ->  Bitmap Index Scan on compress_hyper_2_7_chunk_device__ts_meta_min_1__ts_meta_max_idx
+                     Index Cond: ((device = ANY ('{1,4}'::integer[])) AND (_ts_meta_min_1 <= 'Thu Jun 02 00:00:00 2022 PDT'::timestamp with time zone))
    ->  Custom Scan (DecompressChunk) on _hyper_1_2_chunk
          Vectorized Filter: ("time" <= 'Thu Jun 02 00:00:00 2022 PDT'::timestamp with time zone)
-         ->  Seq Scan on compress_hyper_2_8_chunk
-               Filter: ((_ts_meta_min_1 <= 'Thu Jun 02 00:00:00 2022 PDT'::timestamp with time zone) AND (device = ANY ('{1,4}'::integer[])))
-(9 rows)
+         ->  Bitmap Heap Scan on compress_hyper_2_8_chunk
+               Recheck Cond: ((device = ANY ('{1,4}'::integer[])) AND (_ts_meta_min_1 <= 'Thu Jun 02 00:00:00 2022 PDT'::timestamp with time zone))
+               ->  Bitmap Index Scan on compress_hyper_2_8_chunk_device__ts_meta_min_1__ts_meta_max_idx
+                     Index Cond: ((device = ANY ('{1,4}'::integer[])) AND (_ts_meta_min_1 <= 'Thu Jun 02 00:00:00 2022 PDT'::timestamp with time zone))
+(13 rows)
 
 select sum(humidity) from readings
 where time <= '2022-06-02' and device in (1, 4);