You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merge #1520: Remove integration tests from torrent-repository package
1472c8e refactor: [#1504] remove unneded trait implementationis for Swarm (Jose Celano)
c2dabb2 chore: [#1504] remove uneeded fn attribute (Jose Celano)
8d3b948 tests: [#1504] remove integration tests from torrent-repository pacakge (Jose Celano)
Pull request description:
All features are now covered by unit tests.
I have also removed unused trait implementations for the `Swarm` type. If we need them in the future, we should extract a private type to use derived implementations:
From:
```rust
#[derive(Clone)]
pub struct Swarm {
info_hash: InfoHash,
peers: BTreeMap<SocketAddr, Arc<PeerAnnouncement>>,
metadata: SwarmMetadata,
event_sender: Sender,
}
```
To:
```rust
#[derive(Clone)]
pub struct Swarm {
data: SwarmData,
event_sender: Sender,
}
#[derive(Clone, Debug, Display, Hash, PartialEq, Eq)]
pub struct SwarmData {
info_hash: InfoHash,
peers: BTreeMap<SocketAddr, Arc<PeerAnnouncement>>,
metadata: SwarmMetadata,
}
```
ACKs for top commit:
josecelano:
ACK 1472c8e
Tree-SHA512: f350957ed47f234e41762e523bef66e337176e91011c3fbed4219a10bae44cca11a29e7736392f759d1d67f298553ec0c4a2960bed6817f3035cea8acc0beccf
0 commit comments