Merge #1314: Refactor packages: extract udp-tracker-server package

35c6865 refactor: remove unused code (Jose Celano)
ec6b968 refactor: [#1284] extract udp-tracker-server package (Jose Celano)
b071900 docs: fix crate docs URL (Jose Celano)

Pull request description:

  Refactor packages:  extract `udp-tracker-server` package

ACKs for top commit:
  josecelano:
    ACK 35c6865

Tree-SHA512: 7bb0e7c919d2e2fe5918180e46d791daa95062cd803188f98101bd65f1277cdbde7279219eb8cc26ed7083e83afe306dc05bcec0db2a35f4f3960c1ba00f54ab

Author: josecelano

.github/workflows/deployment.yaml

@@ -76,3 +76,4 @@ jobs:
           cargo publish -p torrust-tracker-primitives
           cargo publish -p torrust-tracker-test-helpers
           cargo publish -p torrust-tracker-torrent-repository
+          cargo publish -p torrust-udp-tracker-server

Cargo.lock

@@ -50,7 +50,6 @@ dashmap = "6"
 derive_more = { version = "2", features = ["as_ref", "constructor", "from"] }
 figment = "0"
 futures = "0"
-futures-util = "0"
 hyper = "1"
 parking_lot = "0"
 percent-encoding = "2"
@@ -60,7 +59,6 @@ r2d2_sqlite = { version = "0", features = ["bundled"] }
 rand = "0"
 regex = "1"
 reqwest = { version = "0", features = ["json"] }
-ringbuf = "0"
 serde = { version = "1", features = ["derive"] }
 serde_bencode = "0"
 serde_bytes = "0"
@@ -76,9 +74,9 @@ torrust-server-lib = { version = "3.0.0-develop", path = "packages/server-lib" }
 torrust-tracker-api-core = { version = "3.0.0-develop", path = "packages/tracker-api-core" }
 torrust-tracker-clock = { version = "3.0.0-develop", path = "packages/clock" }
 torrust-tracker-configuration = { version = "3.0.0-develop", path = "packages/configuration" }
-torrust-tracker-located-error = { version = "3.0.0-develop", path = "packages/located-error" }
 torrust-tracker-primitives = { version = "3.0.0-develop", path = "packages/primitives" }
 torrust-tracker-torrent-repository = { version = "3.0.0-develop", path = "packages/torrent-repository" }
+torrust-udp-tracker-server = { version = "3.0.0-develop", path = "packages/udp-tracker-server" }
 tower = { version = "0", features = ["timeout"] }
 tower-http = { version = "0", features = ["compression-full", "cors", "propagate-header", "request-id", "trace"] }
 tracing = "0"

Cargo.toml

@@ -4,7 +4,7 @@ The Torrust Bittorrent HTTP tracker.
 
 ## Documentation
 
-[Crate documentation](https://docs.rs/torrust-axum-server).
+[Crate documentation](https://docs.rs/torrust-axum-http-tracker-server).
 
 ## License
 

packages/axum-http-tracker-server/README.md

@@ -238,7 +238,7 @@
 //! `info_hash` parameters: `info_hash=%81%00%0...00%00%00&info_hash=%82%00%0...00%00%00`
 //!
 //! > **NOTICE**: the maximum number of torrents you can scrape at the same time
-//! > is `74`. Defined with a hardcoded const [`MAX_SCRAPE_TORRENTS`](crate::shared::bit_torrent::common::MAX_SCRAPE_TORRENTS).
+//! > is `74`. Defined with a hardcoded const [`MAX_SCRAPE_TORRENTS`](torrust_udp_tracker_server::MAX_SCRAPE_TORRENTS).
 //!
 //! **Sample response**
 //!

packages/axum-http-tracker-server/src/lib.rs

@@ -1,8 +1,5 @@
 //! Axum [`handlers`](axum#handlers) for the `announce` requests.
 //!
-//! Refer to [HTTP server](crate::servers::http) for more information about the
-//! `announce` request.
-//!
 //! The handlers perform the authentication and authorization of the request,
 //! and resolve the client IP address.
 use std::sync::Arc;

packages/axum-http-tracker-server/src/v1/handlers/announce.rs

@@ -1,7 +1,4 @@
 //! Axum [`handlers`](axum#handlers) for the HTTP server.
-//!
-//! Refer to the generic [HTTP server documentation](crate::servers::http) for
-//! more information about the HTTP tracker.
 pub mod announce;
 pub mod common;
 pub mod health_check;

packages/axum-http-tracker-server/src/v1/handlers/mod.rs

@@ -1,8 +1,5 @@
 //! Axum [`handlers`](axum#handlers) for the `announce` requests.
 //!
-//! Refer to [HTTP server](crate::servers::http) for more information about the
-//! `scrape` request.
-//!
 //! The handlers perform the authentication and authorization of the request,
 //! and resolve the client IP address.
 use std::sync::Arc;

packages/axum-http-tracker-server/src/v1/handlers/scrape.rs

@@ -1,7 +1,4 @@
 //! HTTP server implementation for the `v1` API.
-//!
-//! Refer to the generic [HTTP server documentation](crate::servers::http) for
-//! more information about the endpoints and their usage.
 pub mod extractors;
 pub mod handlers;
 pub mod routes;

packages/axum-http-tracker-server/src/v1/mod.rs

@@ -131,6 +131,20 @@ pub mod peer_tests;
 pub mod test_helpers;
 
 use torrust_tracker_clock::clock;
+
+/// The maximum number of torrents that can be returned in an `scrape` response.
+///
+/// The [BEP 15. UDP Tracker Protocol for `BitTorrent`](https://www.bittorrent.org/beps/bep_0015.html)
+/// defines this limit:
+///
+/// "Up to about 74 torrents can be scraped at once. A full scrape can't be done
+/// with this protocol."
+///
+/// The [BEP 48. Tracker Protocol Extension: Scrape](https://www.bittorrent.org/beps/bep_0048.html)
+/// does not specifically mention this limit, but the limit is being used for
+/// both the UDP and HTTP trackers since it's applied at the domain level.
+pub const MAX_SCRAPE_TORRENTS: u8 = 74;
+
 /// This code needs to be copied into each crate.
 /// Working version, for production.
 #[cfg(not(test))]