Skip to content

Commit bc95fc4

Browse files
committed
docs: remove code-review comment
We decided not to change it. - The returned value is simpler. - We force the initial peer to change so there is no confusion about what was the final announced peer.
1 parent fd6e902 commit bc95fc4

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

packages/tracker-core/src/announce_handler.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,6 @@ impl AnnounceHandler {
162162
remote_client_ip: &IpAddr,
163163
peers_wanted: &PeersWanted,
164164
) -> Result<AnnounceData, AnnounceError> {
165-
// code-review: maybe instead of mutating the peer we could just return
166-
// a tuple with the new peer and the announce data: (Peer, AnnounceData).
167-
// It could even be a different struct: `StoredPeer` or `PublicPeer`.
168-
169165
self.whitelist_authorization.authorize(info_hash).await?;
170166

171167
tracing::debug!("Before: {peer:?}");

0 commit comments

Comments
 (0)