feat(benchmarks): update performance documentation #1297
Conversation
… benchmarks and improved performance metrics for es-toolkit compared to lodash-es.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
manudeli
requested review from
Copilot
and removed request for
dayongkr and
raon0211
There was a problem hiding this comment.
Pull Request Overview
This PR updates the performance documentation across multiple languages to reflect newer benchmark results using [email protected] instead of 0.0.1. The update includes improved performance metrics showing es-toolkit's advantages over lodash-es and removes some previously mentioned claims about extreme performance gains.
- Updated version information from [email protected] to @1.39.8
- Removed references to "up to 11× performance improvement" claims and performance graph
- Updated benchmark data with newer test results showing consistent performance advantages
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/performance.md | Updated English performance documentation with newer benchmark data |
| docs/zh_hans/performance.md | Updated Chinese (Simplified) performance documentation |
| docs/ko/performance.md | Updated Korean performance documentation |
| docs/ja/performance.md | Updated Japanese performance documentation |
| benchmarks/performance/*.bench.ts | Added lodash-es benchmarks to existing test files for comprehensive comparisons |
| | [dropRightWhile](./reference/array/dropRightWhile.md) | 18,924,422 times | 11,115,819 times | 1.70x | | ||
|
|
||
| テスト環境はMacBook Pro 14インチ（M1 Max、2021）です。[ベンチマークコード](https://github.com/toss/es-toolkit/tree/main/benchmarks)を参照してください。 | ||
| テスト環境はMacBook Pro 16-inch (M1 Max, 2021)です。[ベンチマークコード](https://github.com/toss/es-toolkit/tree/main/benchmarks)を参照してください。 |
There was a problem hiding this comment.
[nitpick] The Japanese text should use consistent formatting for 'MacBook Pro 16-inch'. Consider using Japanese parentheses （） instead of English parentheses () for consistency with Japanese typography conventions, or maintain the English format consistently as in the original.
| テスト環境はMacBook Pro 16-inch (M1 Max, 2021)です。[ベンチマークコード](https://github.com/toss/es-toolkit/tree/main/benchmarks)を参照してください。 | |
| テスト環境はMacBook Pro 16-inch（M1 Max, 2021）です。[ベンチマークコード](https://github.com/toss/es-toolkit/tree/main/benchmarks)を参照してください。 |
|
|
||
|  | ||
|
|
||
| Designed with performance in mind, es-toolkit provides an average of 2× performance improvement compared to alternative libraries like lodash. Some functions achieve up to an 11× performance gain by fully utilizing modern JavaScript APIs. |
There was a problem hiding this comment.
Currently, the difference is not up to 11 times, so this part can be considered an exaggeration, so it is removed.
manudeli
changed the title
| import { difference as differenceToolkit_ } from 'es-toolkit'; | ||
| import { difference as differenceCompatToolkit_ } from 'es-toolkit/compat'; | ||
| import { difference as differenceLodash_ } from 'lodash'; | ||
| import { difference as differenceLodash_es } from 'lodash-es'; |
There was a problem hiding this comment.
As far as I know, there shouldn't be any performance differences between lodash-es and lodash, so I'm wondering what the reason was for adding it?
There was a problem hiding this comment.
The page https://es-toolkit.dev/performance.html uses lodash-es to demonstrate the performance of es-toolkit. so I used lodash-es too
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1297 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 468 468
Lines 4439 4439
Branches 1309 1309
=======================================
Hits 4428 4428
Misses 11 11 🚀 New features to boost your workflow:
|
No description provided.