Skip to content

Conversation

@suinkimme
Copy link

📝 Key Changes

Fixed an issue where the favicon was not loading correctly due to inconsistent path resolution in deep routes.

Problem

  • A relative path such as "images/favicon.ico" was used while base: "/code-quality/" was configured.
  • In practice, the resolved path differed depending on the current route:
    • At the root (/code-quality/), it attempted to load /code-quality/images/favicon.icofailed
    • In deeper routes such as /code-quality/code/detail, it attempted to load /code-quality/code/images/favicon.icosuccessful
  • This inconsistent behavior caused the favicon to fail loading in certain routes.

Problem

  • Updated only the favicon path in the head array of shared.mts to an absolute path that includes the base path.
  • Changed: href: "images/favicon.ico"href: "/code-quality/images/favicon.ico"

🖼️ Before and After Comparison

Before After
href: "images/favicon.ico" href: "/code-quality/images/favicon.ico"
Favicon failed to load at /code-quality/ Favicon loads correctly at all routes

Before

image

After

image

Relative paths caused favicon to fail loading
in deep routes such as /code-quality/code/detail
when a base path was configured. This commit updates the paths
to ensure proper loading across all routes.
@vercel
Copy link

vercel bot commented Nov 27, 2025

@suinkimme is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed the route, so what do you think the ico of the site looks like locally by suinkimme?

I look like this in the version I don't change.

토스

Thank you

Copy link
Author

@suinkimme suinkimme Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-quality의 중첩 경로에서만 favicon이 렌더링되지 않는 이슈가 있었습니다. 이전 페이지에서 가져온 favicon 캐시 때문에 일부 상황에서는 정상적으로 보이는 것처럼 보이기도 했습니다.
어떤 경로에서도 favicon이 올바르게 로드되도록 수정했고, 해당 변경 사항으로 PR도 올렸습니다. 추가로 원하시는 점이 있다면 알려주세요!

제가 영어가 유창한 편이 아니라 혹시 한국어로 어떤 이슈가 있으셨는지 다시 한 번 말씀해주실 수 있으신가요?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저 또한 캐시의 영향인지 정상적으로 ico가 로드되는 상황이 일어나기도 하고, ico가 없는 상황도 발생합니다.
다른 사람들도 동일하게 뜨는지, 그리고 코드를 고쳤을 때에 영구적으로 ico가 잘 뜨는지가 궁금해서 여쭈어보았습니다!

감사합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants