-
Notifications
You must be signed in to change notification settings - Fork 135
Add 3d subcell positivity limiting for nonlinear variables #2647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3d subcell positivity limiting for nonlinear variables #2647
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2647 +/- ##
==========================================
+ Coverage 95.12% 96.85% +1.73%
==========================================
Files 546 546
Lines 43204 43246 +42
==========================================
+ Hits 41096 41885 +789
+ Misses 2108 1361 -747
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think these are so little additions that we can move on and merge this PR without @amrueda's final look. Are you okay with that @DanielDoehring ? |
Sure 👍 |
After the initial 3d subcell limiting PR #2582, this PR adds positivity limiting for nonlinear variables.