From f6bdc6cd12e7aafca34adae5f54fc9f33bc87c43 Mon Sep 17 00:00:00 2001 From: Hendrik Ranocha Date: Tue, 2 Dec 2025 19:26:54 +0100 Subject: [PATCH 01/17] update to TrixiTest.jl v2 --- test/Project.toml | 2 +- test/test_cuda.jl | 2 +- test/test_p4est_2d.jl | 4 ++-- test/test_p4est_3d.jl | 2 +- test/test_structured_2d.jl | 2 +- test/test_tree_2d_mhd.jl | 4 ++-- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/test/Project.toml b/test/Project.toml index 9e714ac3768..5f0fe77d4d8 100644 --- a/test/Project.toml +++ b/test/Project.toml @@ -74,4 +74,4 @@ SparseConnectivityTracer = "1.0.1" SparseMatrixColorings = "0.4.21" StableRNGs = "1.0.2" Test = "1" -TrixiTest = "0.1.4" +TrixiTest = "0.2" diff --git a/test/test_cuda.jl b/test/test_cuda.jl index 87c32ed1e73..f385352c4cc 100644 --- a/test/test_cuda.jl +++ b/test/test_cuda.jl @@ -41,7 +41,7 @@ end # Expected errors are exactly the same as with TreeMesh! l2=nothing, # TODO: GPU. [Float32(8.311947673061856e-6)], linf=nothing, # TODO: GPU. [Float32(6.627000273229378e-5)], - RealT=Float32, + RealT_for_test_tolerances=Float32, real_type=Float32, storage_type=CuArray, sol=nothing,) # TODO: GPU. Remove this once we can run the simulation on the GPU diff --git a/test/test_p4est_2d.jl b/test/test_p4est_2d.jl index 212276f0ddd..b35237817a8 100644 --- a/test/test_p4est_2d.jl +++ b/test/test_p4est_2d.jl @@ -35,7 +35,7 @@ end # Expected errors are exactly the same as with TreeMesh! l2=[Float32(8.311947673061856e-6)], linf=[Float32(6.627000273229378e-5)], - RealT=Float32, + RealT_for_test_tolerances=Float32, real_type=Float32) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities) @@ -278,7 +278,7 @@ end ], tspan=(0.0f0, 1.0f0), rtol=10 * sqrt(eps(Float32)), # to make CI pass - RealT=Float32) + RealT_for_test_tolerances=Float32) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities) @test_allocations(Trixi.rhs!, semi, sol, 1000) diff --git a/test/test_p4est_3d.jl b/test/test_p4est_3d.jl index 42aba382f89..174fc879310 100644 --- a/test/test_p4est_3d.jl +++ b/test/test_p4est_3d.jl @@ -228,7 +228,7 @@ end Float32(2.298161660974074e-14), Float32(6.039613253960852e-14) ], - RealT=Float32) + RealT_for_test_tolerances=Float32) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities) @test_allocations(Trixi.rhs!, semi, sol, 1000) diff --git a/test/test_structured_2d.jl b/test/test_structured_2d.jl index b8f861f84b7..2b60fcccd91 100644 --- a/test/test_structured_2d.jl +++ b/test/test_structured_2d.jl @@ -30,7 +30,7 @@ end # Expected errors are taken from elixir_advection_basic.jl l2=[Float32(8.311947673061856e-6)], linf=[Float32(6.627000273229378e-5)], - RealT=Float32) + RealT_for_test_tolerances=Float32) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities) @test_allocations(Trixi.rhs!, semi, sol, 1000) diff --git a/test/test_tree_2d_mhd.jl b/test/test_tree_2d_mhd.jl index 0f5fb24ae93..5163018152c 100644 --- a/test/test_tree_2d_mhd.jl +++ b/test/test_tree_2d_mhd.jl @@ -177,7 +177,7 @@ end 0.09208131, 0.14795369, 2.2078211f-6], - RealT=Float32) + RealT_for_test_tolerances=Float32) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities) @test_allocations(Trixi.rhs!, semi, sol, 1000) @@ -402,7 +402,7 @@ end # In the `StepsizeCallback`, though, the less diffusive `max_abs_speeds` is employed which is consistent with `max_abs_speed`. # Thus, we exchanged in PR#2458 the default wave speed used in the LLF flux to `max_abs_speed`. # To ensure that every example still runs we specify explicitly `FluxLaxFriedrichs(max_abs_speed_naive)`. - # We remark, however, that the now default `max_abs_speed` is in general recommended due to compliance with the + # We remark, however, that the now default `max_abs_speed` is in general recommended due to compliance with the # `StepsizeCallback` (CFL-Condition) and less diffusion. surface_flux=(FluxLaxFriedrichs(max_abs_speed_naive), flux_nonconservative_powell_local_jump), From 5a4d24c35eb0801dc9ac676bb4b0e6b78b3247ef Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Tue, 2 Dec 2025 22:24:44 +0000 Subject: [PATCH 02/17] up --- test/test_structured_2d.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test_structured_2d.jl b/test/test_structured_2d.jl index 2b60fcccd91..a439629e843 100644 --- a/test/test_structured_2d.jl +++ b/test/test_structured_2d.jl @@ -28,8 +28,8 @@ end # Expected errors are taken from elixir_advection_basic.jl @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_float32.jl"), # Expected errors are taken from elixir_advection_basic.jl - l2=[Float32(8.311947673061856e-6)], - linf=[Float32(6.627000273229378e-5)], + l2=8.477608f-6, + linf=7.224083f-5, RealT_for_test_tolerances=Float32) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities) From c07784ac37d7df97994d00b831dc237d3fff968c Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Tue, 2 Dec 2025 22:32:59 +0000 Subject: [PATCH 03/17] up --- test/test_p4est_3d.jl | 20 ++++++++++---------- test/test_tree_2d_mhd.jl | 37 +++++++++++++++++++------------------ 2 files changed, 29 insertions(+), 28 deletions(-) diff --git a/test/test_p4est_3d.jl b/test/test_p4est_3d.jl index 174fc879310..499002892ce 100644 --- a/test/test_p4est_3d.jl +++ b/test/test_p4est_3d.jl @@ -215,18 +215,18 @@ end @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_euler_free_stream_boundaries_float32.jl"), l2=[ - Float32(6.530157034651212e-16), - Float32(1.6057829680004379e-15), - Float32(3.31107455378537e-15), - Float32(3.908829498281281e-15), - Float32(5.048390610424672e-15) + 3.8734996f-7, + 1.2929888f-6, + 2.4713074f-6, + 2.9541036f-6, + 3.292966f-6 ], linf=[ - Float32(4.884981308350689e-15), - Float32(1.1921019726912618e-14), - Float32(1.5432100042289676e-14), - Float32(2.298161660974074e-14), - Float32(6.039613253960852e-14) + 2.8014183f-6, + 9.417534f-6, + 1.1667609f-5, + 1.692772f-5, + 3.33786f-5 ], RealT_for_test_tolerances=Float32) # Ensure that we do not have excessive memory allocations diff --git a/test/test_tree_2d_mhd.jl b/test/test_tree_2d_mhd.jl index 5163018152c..68ef2c03eb1 100644 --- a/test/test_tree_2d_mhd.jl +++ b/test/test_tree_2d_mhd.jl @@ -159,24 +159,25 @@ end @trixi_testset "elixir_mhd_ec_float32.jl" begin @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_mhd_ec_float32.jl"), - l2=Float32[0.03635566, - 0.042947732, - 0.042947736, - 0.025748001, - 0.16211228, - 0.01745248, - 0.017452491, - 0.026877586, - 2.417227f-7], - linf=Float32[0.2210092, - 0.28798974, - 0.28799006, - 0.20858109, - 0.8812673, - 0.09208107, - 0.09208131, - 0.14795369, - 2.2078211f-6], + l2=[0.036355633f0, + 0.042947736f0, + 0.042947732f0, + 0.025748007f0, + 0.16211234f0, + 0.017452473f0, + 0.017452475f0, + 0.026877586, + 2.4459175f-7], + linf=[0.22100985f0, + 0.28798956f0, + 0.28799006f0, + 0.20858262f0, + 0.88126993f0, + 0.09208238f0, + 0.092081904f0, + 0.092081904f0, + 0.14795405f0, + 2.2979193f-6], RealT_for_test_tolerances=Float32) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities) From b165da4bcb0537fab487428bff787034d9779d10 Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Tue, 2 Dec 2025 22:33:31 +0000 Subject: [PATCH 04/17] up --- examples/p4est_2d_dgsem/elixir_advection_basic_gpu.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/p4est_2d_dgsem/elixir_advection_basic_gpu.jl b/examples/p4est_2d_dgsem/elixir_advection_basic_gpu.jl index 6f9e8e56986..75dbb2d261e 100644 --- a/examples/p4est_2d_dgsem/elixir_advection_basic_gpu.jl +++ b/examples/p4est_2d_dgsem/elixir_advection_basic_gpu.jl @@ -19,7 +19,7 @@ coordinates_max = (1.0, 1.0) # maximum coordinates (max(x), max(y)) trees_per_dimension = (8, 8) # Create P4estMesh with 8 x 8 trees and 16 x 16 elements -mesh = P4estMesh(trees_per_dimension, polydeg = 3, +mesh = P4estMesh(trees_per_dimension, polydeg = 3, RealT = Float64, coordinates_min = coordinates_min, coordinates_max = coordinates_max, initial_refinement_level = 1) From c89abb7a0766cc09dcf23927453868344db34cc9 Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Tue, 2 Dec 2025 23:36:24 +0100 Subject: [PATCH 05/17] Update test/test_tree_2d_mhd.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- test/test_tree_2d_mhd.jl | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/test/test_tree_2d_mhd.jl b/test/test_tree_2d_mhd.jl index 68ef2c03eb1..4b11ba61fa2 100644 --- a/test/test_tree_2d_mhd.jl +++ b/test/test_tree_2d_mhd.jl @@ -169,15 +169,15 @@ end 0.026877586, 2.4459175f-7], linf=[0.22100985f0, - 0.28798956f0, - 0.28799006f0, - 0.20858262f0, - 0.88126993f0, - 0.09208238f0, - 0.092081904f0, - 0.092081904f0, - 0.14795405f0, - 2.2979193f-6], + 0.28798956f0, + 0.28799006f0, + 0.20858262f0, + 0.88126993f0, + 0.09208238f0, + 0.092081904f0, + 0.092081904f0, + 0.14795405f0, + 2.2979193f-6], RealT_for_test_tolerances=Float32) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities) From 614f8342768747a194a1b45d495543cbc2075087 Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Tue, 2 Dec 2025 23:38:08 +0100 Subject: [PATCH 06/17] Update test/test_p4est_2d.jl --- test/test_p4est_2d.jl | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_p4est_2d.jl b/test/test_p4est_2d.jl index b35237817a8..60b37e610c9 100644 --- a/test/test_p4est_2d.jl +++ b/test/test_p4est_2d.jl @@ -35,6 +35,7 @@ end # Expected errors are exactly the same as with TreeMesh! l2=[Float32(8.311947673061856e-6)], linf=[Float32(6.627000273229378e-5)], + RealT=Float32, RealT_for_test_tolerances=Float32, real_type=Float32) # Ensure that we do not have excessive memory allocations From 9b7329687f0ccc905ccd11b9fb1a6f0d5e091d54 Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Tue, 2 Dec 2025 23:57:05 +0100 Subject: [PATCH 07/17] Update test/test_tree_2d_mhd.jl --- test/test_tree_2d_mhd.jl | 1 - 1 file changed, 1 deletion(-) diff --git a/test/test_tree_2d_mhd.jl b/test/test_tree_2d_mhd.jl index 4b11ba61fa2..0baad71082a 100644 --- a/test/test_tree_2d_mhd.jl +++ b/test/test_tree_2d_mhd.jl @@ -175,7 +175,6 @@ end 0.88126993f0, 0.09208238f0, 0.092081904f0, - 0.092081904f0, 0.14795405f0, 2.2979193f-6], RealT_for_test_tolerances=Float32) From 9b408ab12dd210e54978bb2f211bd0edd355e426 Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Tue, 2 Dec 2025 23:18:42 +0000 Subject: [PATCH 08/17] change --- test/test_p4est_2d.jl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/test_p4est_2d.jl b/test/test_p4est_2d.jl index b35237817a8..781cc1fc370 100644 --- a/test/test_p4est_2d.jl +++ b/test/test_p4est_2d.jl @@ -26,8 +26,7 @@ isdir(outdir) && rm(outdir, recursive = true) @test real(semi32.solver) == Float32 @test real(semi32.solver.basis) == Float32 @test real(semi32.solver.mortar) == Float32 - # TODO: remake ignores the mesh itself as well - @test real(semi32.mesh) == Float64 + @test real(semi32.mesh) == Float32 end @trixi_testset "elixir_advection_basic.jl (Float32)" begin From 56fd73efeea679cd8642fca4750dbca2d7a7bff9 Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Wed, 3 Dec 2025 08:42:30 +0100 Subject: [PATCH 09/17] Apply suggestions from code review --- examples/p4est_2d_dgsem/elixir_advection_basic_gpu.jl | 2 +- test/test_p4est_2d.jl | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/p4est_2d_dgsem/elixir_advection_basic_gpu.jl b/examples/p4est_2d_dgsem/elixir_advection_basic_gpu.jl index 75dbb2d261e..6f9e8e56986 100644 --- a/examples/p4est_2d_dgsem/elixir_advection_basic_gpu.jl +++ b/examples/p4est_2d_dgsem/elixir_advection_basic_gpu.jl @@ -19,7 +19,7 @@ coordinates_max = (1.0, 1.0) # maximum coordinates (max(x), max(y)) trees_per_dimension = (8, 8) # Create P4estMesh with 8 x 8 trees and 16 x 16 elements -mesh = P4estMesh(trees_per_dimension, polydeg = 3, RealT = Float64, +mesh = P4estMesh(trees_per_dimension, polydeg = 3, coordinates_min = coordinates_min, coordinates_max = coordinates_max, initial_refinement_level = 1) diff --git a/test/test_p4est_2d.jl b/test/test_p4est_2d.jl index 63de9738cfe..279e57b253c 100644 --- a/test/test_p4est_2d.jl +++ b/test/test_p4est_2d.jl @@ -26,7 +26,8 @@ isdir(outdir) && rm(outdir, recursive = true) @test real(semi32.solver) == Float32 @test real(semi32.solver.basis) == Float32 @test real(semi32.solver.mortar) == Float32 - @test real(semi32.mesh) == Float32 + # TODO: `mesh` is currently not `adapt`ed correctly + @test real(semi32.mesh) == Float64 end @trixi_testset "elixir_advection_basic.jl (Float32)" begin From 75051bc16b5f2ae86c33f9135d3f3b281a8fe0e6 Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Wed, 3 Dec 2025 08:27:42 +0000 Subject: [PATCH 10/17] fix --- test/test_p4est_2d.jl | 1 - 1 file changed, 1 deletion(-) diff --git a/test/test_p4est_2d.jl b/test/test_p4est_2d.jl index 63de9738cfe..781cc1fc370 100644 --- a/test/test_p4est_2d.jl +++ b/test/test_p4est_2d.jl @@ -34,7 +34,6 @@ end # Expected errors are exactly the same as with TreeMesh! l2=[Float32(8.311947673061856e-6)], linf=[Float32(6.627000273229378e-5)], - RealT=Float32, RealT_for_test_tolerances=Float32, real_type=Float32) # Ensure that we do not have excessive memory allocations From cba61fb47e99dd6c3585a7bdfbb7c522dbb122cd Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Wed, 3 Dec 2025 08:29:21 +0000 Subject: [PATCH 11/17] comments --- test/test_cuda.jl | 4 ++-- test/test_p4est_2d.jl | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test_cuda.jl b/test/test_cuda.jl index f385352c4cc..1ab80769c99 100644 --- a/test/test_cuda.jl +++ b/test/test_cuda.jl @@ -22,7 +22,7 @@ EXAMPLES_DIR = joinpath(examples_dir(), "p4est_2d_dgsem") @test real(ode.p.solver) == Float64 @test real(ode.p.solver.basis) == Float64 @test real(ode.p.solver.mortar) == Float64 - # TODO: remake ignores the mesh itself as well + # TODO: `mesh` is currently not `adapt`ed correctly @test real(ode.p.mesh) == Float64 @test ode.u0 isa Array @@ -51,7 +51,7 @@ end @test real(ode.p.solver) == Float32 @test real(ode.p.solver.basis) == Float32 @test real(ode.p.solver.mortar) == Float32 - # TODO: remake ignores the mesh itself as well + # TODO: `mesh` is currently not `adapt`ed correctly @test real(ode.p.mesh) == Float64 @test ode.u0 isa CuArray diff --git a/test/test_p4est_2d.jl b/test/test_p4est_2d.jl index 1c2b4e1ac95..ca6af4c24ff 100644 --- a/test/test_p4est_2d.jl +++ b/test/test_p4est_2d.jl @@ -48,7 +48,7 @@ end @test real(ode.p.solver) == Float32 @test real(ode.p.solver.basis) == Float32 @test real(ode.p.solver.mortar) == Float32 - # TODO: remake ignores the mesh itself as well + # TODO: `mesh` is currently not `adapt`ed correctly @test real(ode.p.mesh) == Float64 end From 9af7836de0fd30c1f665a3d400a37ef5e0cd487b Mon Sep 17 00:00:00 2001 From: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com> Date: Wed, 3 Dec 2025 11:29:22 +0100 Subject: [PATCH 12/17] Update test/Project.toml --- test/Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/Project.toml b/test/Project.toml index 5f0fe77d4d8..e2d2243c855 100644 --- a/test/Project.toml +++ b/test/Project.toml @@ -74,4 +74,4 @@ SparseConnectivityTracer = "1.0.1" SparseMatrixColorings = "0.4.21" StableRNGs = "1.0.2" Test = "1" -TrixiTest = "0.2" +TrixiTest = "0.2.1" From 959b4840ca2cd1e24d5a4dad0c8aad7057090c51 Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Wed, 3 Dec 2025 11:47:10 +0100 Subject: [PATCH 13/17] Apply suggestions from code review --- test/test_p4est_3d.jl | 10 +++++----- test/test_tree_2d_mhd.jl | 36 ++++++++++++++++++------------------ 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/test/test_p4est_3d.jl b/test/test_p4est_3d.jl index 499002892ce..ccc64bda6d8 100644 --- a/test/test_p4est_3d.jl +++ b/test/test_p4est_3d.jl @@ -222,11 +222,11 @@ end 3.292966f-6 ], linf=[ - 2.8014183f-6, - 9.417534f-6, - 1.1667609f-5, - 1.692772f-5, - 3.33786f-5 + Float32(4.884981308350689e-15), + Float32(1.1921019726912618e-14), + Float32(1.5432100042289676e-14), + Float32(2.298161660974074e-14), + Float32(6.039613253960852e-14) ], RealT_for_test_tolerances=Float32) # Ensure that we do not have excessive memory allocations diff --git a/test/test_tree_2d_mhd.jl b/test/test_tree_2d_mhd.jl index 0baad71082a..5163018152c 100644 --- a/test/test_tree_2d_mhd.jl +++ b/test/test_tree_2d_mhd.jl @@ -159,24 +159,24 @@ end @trixi_testset "elixir_mhd_ec_float32.jl" begin @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_mhd_ec_float32.jl"), - l2=[0.036355633f0, - 0.042947736f0, - 0.042947732f0, - 0.025748007f0, - 0.16211234f0, - 0.017452473f0, - 0.017452475f0, - 0.026877586, - 2.4459175f-7], - linf=[0.22100985f0, - 0.28798956f0, - 0.28799006f0, - 0.20858262f0, - 0.88126993f0, - 0.09208238f0, - 0.092081904f0, - 0.14795405f0, - 2.2979193f-6], + l2=Float32[0.03635566, + 0.042947732, + 0.042947736, + 0.025748001, + 0.16211228, + 0.01745248, + 0.017452491, + 0.026877586, + 2.417227f-7], + linf=Float32[0.2210092, + 0.28798974, + 0.28799006, + 0.20858109, + 0.8812673, + 0.09208107, + 0.09208131, + 0.14795369, + 2.2078211f-6], RealT_for_test_tolerances=Float32) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities) From 53402530938f1ba59284583241af3ebaeb5cce05 Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Wed, 3 Dec 2025 11:47:30 +0100 Subject: [PATCH 14/17] Update test/test_structured_2d.jl --- test/test_structured_2d.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test_structured_2d.jl b/test/test_structured_2d.jl index a439629e843..1d12b4e12b0 100644 --- a/test/test_structured_2d.jl +++ b/test/test_structured_2d.jl @@ -28,8 +28,8 @@ end # Expected errors are taken from elixir_advection_basic.jl @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_float32.jl"), # Expected errors are taken from elixir_advection_basic.jl - l2=8.477608f-6, - linf=7.224083f-5, + l2=[Float32(8.311947673061856e-6)], + linf=[Float32(6.627000273229378e-5)] RealT_for_test_tolerances=Float32) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities) From cc9ca0a1a91e6ef00ada8c7e8bf2fd02c8654867 Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Wed, 3 Dec 2025 11:47:43 +0100 Subject: [PATCH 15/17] Update test/test_p4est_3d.jl --- test/test_p4est_3d.jl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/test_p4est_3d.jl b/test/test_p4est_3d.jl index ccc64bda6d8..174fc879310 100644 --- a/test/test_p4est_3d.jl +++ b/test/test_p4est_3d.jl @@ -215,11 +215,11 @@ end @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_euler_free_stream_boundaries_float32.jl"), l2=[ - 3.8734996f-7, - 1.2929888f-6, - 2.4713074f-6, - 2.9541036f-6, - 3.292966f-6 + Float32(6.530157034651212e-16), + Float32(1.6057829680004379e-15), + Float32(3.31107455378537e-15), + Float32(3.908829498281281e-15), + Float32(5.048390610424672e-15) ], linf=[ Float32(4.884981308350689e-15), From fe57439222cfe86b19c2b74b2e4bcd2c832c4afa Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Wed, 3 Dec 2025 11:48:41 +0100 Subject: [PATCH 16/17] Update test/test_structured_2d.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- test/test_structured_2d.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_structured_2d.jl b/test/test_structured_2d.jl index 1d12b4e12b0..071ae66db2f 100644 --- a/test/test_structured_2d.jl +++ b/test/test_structured_2d.jl @@ -30,7 +30,7 @@ end # Expected errors are taken from elixir_advection_basic.jl l2=[Float32(8.311947673061856e-6)], linf=[Float32(6.627000273229378e-5)] - RealT_for_test_tolerances=Float32) + RealT_for_test_tolerances = Float32) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities) @test_allocations(Trixi.rhs!, semi, sol, 1000) From 18c0e2c7b7edb4489c0899d9f8886700cbb8235a Mon Sep 17 00:00:00 2001 From: Daniel Doehring Date: Wed, 3 Dec 2025 11:50:42 +0100 Subject: [PATCH 17/17] Update test/test_structured_2d.jl --- test/test_structured_2d.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test_structured_2d.jl b/test/test_structured_2d.jl index 071ae66db2f..2b60fcccd91 100644 --- a/test/test_structured_2d.jl +++ b/test/test_structured_2d.jl @@ -29,8 +29,8 @@ end @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_float32.jl"), # Expected errors are taken from elixir_advection_basic.jl l2=[Float32(8.311947673061856e-6)], - linf=[Float32(6.627000273229378e-5)] - RealT_for_test_tolerances = Float32) + linf=[Float32(6.627000273229378e-5)], + RealT_for_test_tolerances=Float32) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities) @test_allocations(Trixi.rhs!, semi, sol, 1000)