Implement rotation for components in Move Components mode #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the ability to rotate components when in "Move Components" mode. - A rotation handle (a small circle) has been added to the top-right corner of a selected component's bounding box. - Users can click and drag this handle to rotate the component. - A new `edit_pcb_component_rotation` manual edit event is created to store the rotation changes. - The component's rotation is visually updated in the PCB viewer.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+135
to
+142
| const angle = Math.atan2( | ||
| rwMousePoint.y - component.center.y, | ||
| rwMousePoint.x - component.center.x, | ||
| ) | ||
| onModifyEditEvent({ | ||
| edit_event_id: rotationState.edit_event_id, | ||
| new_rotation: rotationState.original_rotation + angle, | ||
| } as any) |
There was a problem hiding this comment.
The current rotation implementation causes an abrupt snap when rotation begins because it doesn't account for the initial angle between the mouse and component center.
To create a smoother rotation experience:
- Store the initial mouse-to-component angle when rotation starts:
onMouseDown={(e) => {
// existing code...
const initialAngle = Math.atan2(
mouseY - component.center.y,
mouseX - component.center.x
);
setRotationState({
pcb_component_id: activePcbComponentId!,
edit_event_id,
original_rotation,
initialMouseAngle: initialAngle
});
}- Then calculate rotation based on the difference between current and initial angles:
onMouseMove={(e) => {
// existing code...
const currentAngle = Math.atan2(
rwMousePoint.y - component.center.y,
rwMousePoint.x - component.center.x
);
const angleDelta = currentAngle - rotationState.initialMouseAngle;
onModifyEditEvent({
edit_event_id: rotationState.edit_event_id,
new_rotation: rotationState.original_rotation + angleDelta,
});
}This approach preserves the component's initial orientation and allows for more intuitive rotation control.
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
Author
|
@seveibar please review |
1 similar comment
Author
|
@seveibar please review |
imrishabh18
requested changes
Nov 4, 2025
Author
|
@imrishabh18 So i should close it or what ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #92
/fixes #92
This PR introduces the ability to rotate components when in "Move Components" mode.
edit_pcb_component_rotationmanual edit event is created to store the rotation changes.DEMO VIDEO :
@tscircuit_pcb-viewer.-.Brave.2025-11-04.10-37-52.mp4