Skip to content

Commit 8d511ec

Browse files
authored
Improve readability of job for checking inputs and outputs (#46)
1 parent 6fc06d3 commit 8d511ec

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

.github/workflows/test.main.kts

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,8 @@ private fun checkInputAndOutputNames() {
112112
var shouldFail = false
113113

114114
for (action in actions) {
115-
println("\uFE0F For ${action.owner}/${listOfNotNull(action.name, action.path).joinToString("/")}@${action.version}:")
115+
println()
116+
println("\uFE0F For https://github.com/${action.owner}/${action.name}/tree/${action.version}/${action.path ?: ""}")
116117
val typings = loadTypings(path = action.pathToTypings)
117118
val typingsInputs = if ("inputs" in typings) (typings["inputs"] as Map<String, Any>).keys else emptySet()
118119
val typingsOutputs = if ("outputs" in typings) (typings["outputs"] as Map<String, Any>).keys else emptySet()
@@ -129,14 +130,18 @@ private fun checkInputAndOutputNames() {
129130

130131
if (typingsInputs != manifestInputs || typingsOutputs != manifestOutputs) {
131132
println("\uD83D\uDD34 Something is wrong with the typings!")
132-
println("Typings inputs: $typingsInputs")
133-
println("Manifest inputs: $manifestInputs")
134-
println("Extra inputs in typings: ${typingsInputs - manifestInputs}")
135-
println("Extra inputs in manifest: ${manifestInputs - typingsInputs}")
136-
println("Typings outputs: $typingsOutputs")
137-
println("Manifest outputs: $manifestOutputs")
138-
println("Extra outputs in typings: ${typingsOutputs - manifestOutputs}")
139-
println("Extra outputs in manifest: ${manifestOutputs - typingsOutputs}")
133+
(typingsInputs - manifestInputs).let {
134+
if (it.isNotEmpty()) { println("Extra inputs in typings: $it") }
135+
}
136+
(manifestInputs - typingsInputs).let {
137+
if (it.isNotEmpty()) { println("Extra inputs in manifest: $it") }
138+
}
139+
(typingsOutputs - manifestOutputs).let {
140+
if (it.isNotEmpty()) { println("Extra outputs in typings: $it") }
141+
}
142+
(manifestOutputs - typingsOutputs).let {
143+
if (it.isNotEmpty()) { println("Extra outputs in manifest: $it") }
144+
}
140145
shouldFail = true
141146
continue
142147
}

0 commit comments

Comments
 (0)