Question on boto3 traces

[berkowitzi]

cc @Jamim

We're finding that the boto3 patcher is not successfully patching our boto3 API calls and are wondering if you can discuss your approach and whether it has any shortcomings. Example snippets of boto3 calls that you would expect to be properly instrumented - particularly focusing on s3 usage would be much appreciated!

Apologies for the vague question, our investigation continues but we'd love any input you could provide.
Thanks!

[Jamim]

Hello @berkowitzi,

I'll prepare some snippets tomorrow.
Also, feel free to ping me if I don't provide them within the next 24 hours.

Best regards!

[Jamim]

Hi @berkowitzi,

Working on snippets for you, I found that the S3 client is implemented in a different way than the rest of boto3.
Unfortunately, I didn't notice this initially, so opentracing-instrumentation doesn't support S3 yet.

The good new is I already started implementing support for S3.
I'll let you know as soon as it is ready for testing.

Thanks for your patience!

[yurishkuro]

I think this repo overall could've used examples/ dir to show how various integrations could be used.

[Jamim]

Hey @berkowitzi,

I've created a demo that shows Boto 3 instrumentation:
https://github.com/Jamim/opentracing-boto3-demo

Let's say Thank you to @yurishkuro for quick acceptance of the improvements and releasing the updated version! 👏

Please let us know whether this issue might be closed.

Cheers!

[Jamim]

Hi @berkowitzi,
Could you please provide any feedback?
Thanks!