update unit test for user group

Author: LanThuyNguyen

src/Umbraco.Cms.Api.Management/ViewModels/UserGroup/UserGroupBase.cs

@@ -22,6 +22,11 @@ public class UserGroupBase
     /// </summary>
     public required string Alias { get; init; }
 
+    /// <summary>
+    /// The description of the user group
+    /// </summary>
+    public string? Description { get; set; }
+
     /// <summary>
     /// The Icon for the user group
     /// </summary>
@@ -79,9 +84,4 @@ public class UserGroupBase
     /// </summary>
     public required ISet<string> FallbackPermissions { get; init; }
     public required ISet<IPermissionPresentationModel> Permissions { get; init; }
-
-    /// <summary>
-    /// The description of the user group
-    /// </summary>
-    public string? Description { get; set; }
 }

src/Umbraco.Core/Models/Membership/IReadOnlyUserGroup.cs

@@ -9,6 +9,10 @@ public interface IReadOnlyUserGroup
 {
     string? Name { get; }
 
+    string Alias { get; }
+
+    string? Description { get { return null; } }
+
     string? Icon { get; }
 
     int Id { get; }
@@ -19,11 +23,6 @@ public interface IReadOnlyUserGroup
 
     int? StartMediaId { get; }
 
-    /// <summary>
-    ///     The alias
-    /// </summary>
-    string Alias { get; }
-
     // This is set to return true as default to avoid breaking changes.
     bool HasAccessToAllLanguages => true;
 
@@ -36,6 +35,4 @@ public interface IReadOnlyUserGroup
     IEnumerable<int> AllowedLanguages => Enumerable.Empty<int>();
 
     public bool HasAccessToLanguage( int languageId) => HasAccessToAllLanguages || AllowedLanguages.Contains(languageId);
-
-    string? Description { get; }
-    }
+}

src/Umbraco.Core/Models/Membership/IUserGroup.cs

@@ -25,7 +25,10 @@ public interface IUserGroup : IEntity, IRememberBeingDirty
     /// <summary>
     ///    The description
     /// </summary>
-    string? Description { get; set; }
+    string? Description {
+        get => null;
+        set { }
+    }
 
     /// <summary>
     ///     If this property is true it will give the group access to all languages

src/Umbraco.Infrastructure/Migrations/Upgrade/UmbracoPlan.cs

@@ -143,7 +143,9 @@ protected virtual void DefinePlan()
 
         // To 17.0.1
         To<V_17_0_1.EnsureUmbracoPropertyDataColumnCasing>("{BE5CA411-E12D-4455-A59E-F12A669E5363}");
-        To<V_17_0_1.AddDescriptionToUserGroup>("{D3C5E3C4-1F4C-4D1A-8E2C-1C8D8E2F5B6A}");
+
+        // To 17.1.0
+        To<V_17_1_0.AddDescriptionToUserGroup>("{F1A2B3C4-D5E6-4789-ABCD-1234567890AB}");
 
         // To 18.0.0
         // TODO (V18): Enable on 18 branch

src/Umbraco.Infrastructure/Migrations/Upgrade/V_17_0_1/AddDescriptionToUserGroup.cs

@@ -0,0 +1,40 @@
+using Umbraco.Cms.Core;
+using Umbraco.Cms.Infrastructure.Persistence.Dtos;
+
+namespace Umbraco.Cms.Infrastructure.Migrations.Upgrade.V_17_1_0
+{
+    /// <summary>
+    /// Migration to add a description column to the user group table.
+    /// </summary>
+    public class AddDescriptionToUserGroup : AsyncMigrationBase
+    {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="AddDescriptionToUserGroup"/> class.
+        /// </summary>
+        /// <param name="context">The migration context.</param>
+        public AddDescriptionToUserGroup(
+            IMigrationContext context)
+            : base(context)
+        {
+        }
+
+        /// <inheritdoc/>
+        protected override async Task MigrateAsync()
+        {
+            if (TableExists(Constants.DatabaseSchema.Tables.UserGroup))
+            {
+                return;
+            }
+
+            string columnName = "description";
+            var hasColumn = Context.SqlContext.SqlSyntax.GetColumnsInSchema(Context.Database).ToList().Any(c =>
+            c.TableName == Constants.DatabaseSchema.Tables.UserGroup &&
+            c.ColumnName == columnName);
+
+            if (!hasColumn)
+            {
+                AddColumn<UserGroupDto>(Constants.DatabaseSchema.Tables.UserGroup, columnName);
+            }
+        }
+    }
+}

src/Umbraco.Infrastructure/Migrations/Upgrade/V_17_1_0/AddDescriptionToUserGroup.cs

@@ -193,6 +193,7 @@ export class UmbLinkPickerModalElement extends UmbModalBaseElement<UmbLinkPicker
 		const query = (event.target.value as string) ?? '';
 		if (query.startsWith('#') || query.startsWith('?')) {
 			this.#partialUpdateLink({ queryString: query });
+			this.#validationContext.messages.removeMessageByKey('UmbLinkPickerValueValidator');
 			return;
 		}
 
@@ -202,6 +203,7 @@ export class UmbLinkPickerModalElement extends UmbModalBaseElement<UmbLinkPicker
 			this.#partialUpdateLink({ queryString: `#${query}` });
 		} else {
 			this.#partialUpdateLink({ queryString: '' });
+			this.#validationContext.messages.removeMessageByKey('UmbLinkPickerValueValidator');
 		}
 	}
 
@@ -233,6 +235,7 @@ export class UmbLinkPickerModalElement extends UmbModalBaseElement<UmbLinkPicker
 			type: 'external',
 			url,
 		});
+		this.#validationContext.messages.removeMessageByKey('UmbLinkPickerValueValidator');
 	}
 
 	async #onPickerSelection(event: UmbInputPickerEvent, type: 'document' | 'media') {